357481 - Tasks with 'floating' timezone are not displayed

Status: VERIFIED FIXED

(Calendar :: Provider: Local Storage, defect)

Description

[Stefan Sitter [:ssitter]]

Tasks with 'floating' timezone are not displayed

Steps to Reproduce:
1. Import attached ics file into storage calendar
2. Check task list and calendar view

Actual Results:
'Task 1 - with timezone' is displayed. 'Task 2 - UTC' is displayed.
'Task 3 - floating' is not displayed.

Expected Results:
'Task 3 - floating' is displayed too.

Additional Information:
Steps above work fine for ics provider.
Using 3rd party tool to inspect 'storage.sdb' file showed that all three tasks were imported successfully.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: ics testcase

Testcase contains three simple tasks:
Task 1 using datetimes with timezone '/mozilla.org/20050126_1/Europe/Berlin'
Task 2 using datetimes in UTC
Task 3 using 'floating' datetimes

Comment 2

[Matthew (lilmatt) Willis]

Attachment: fixes typo in storage provider's getItems() if (wantTodos)

Comment 3

[Matthew (lilmatt) Willis]

If you import the testcase before applying this patch, you'll see only the two non-floating tasks in the todo unifinder.  Once you apply this patch, you'll see all three.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 242994 [details] [diff] [review]
fixes typo in storage provider's getItems() if (wantTodos)

r=mvl

Comment 5

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 6

[Matthew (lilmatt) Willis]

Patch checked in for 0.3.1

LIGHTNING_0_3_BRANCH:
Checking in providers/storage/calStorageCalendar.js;
/cvsroot/mozilla/calendar/providers/storage/calStorageCalendar.js,v  <--  calStorageCalendar.js
new revision: 1.61.2.23.2.1; previous revision: 1.61.2.23

SUNBIRD_0_3_BRANCH:
Checking in providers/storage/calStorageCalendar.js;
/cvsroot/mozilla/calendar/providers/storage/calStorageCalendar.js,v  <--  calStorageCalendar.js
new revision: 1.94.2.1; previous revision: 1.94

Marking [fixed0.3.1]

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verifying fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20070129 Calendar/0.3.1pre - Build ID: 2007012905

Comment 8

[cmtalbert]

Verfied: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20070203 Sunbird/0.3.1