357568 - The composition/preedit string of IM is not committed by mouse click if the editor is content of the web pages

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The composition string of IM is not committed by mouse click event if the editor is a content of the web pages. If the editor is a content of toolbar(e.g., search bar and location bar), it is committed by mouse click event.

This is a bug of the patch for bug 321468.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

Now, the timing of the initializing the IME data is only occurred on the widget getting the focus at first time. But the methods of nsIKBStateControl are called at non-related to the timing. Therefore, we should initialize at the methods called if the initializing has not done.

Comment 2

[Masaki Katakai]

Comment on attachment 243088 [details] [diff] [review]
Patch rv1.0

Looks OK for me.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 243088 [details] [diff] [review]
Patch rv1.0

Thank you, Katakai-san for your review.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

How about adding "if (mIMEData) return;" to nsWindow::IMEInitData, so we don't have to add that check everywhere?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.1

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 243738 [details] [diff] [review]
Patch rv1.1

thank you Nakano-san!

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Sorry, for the delay, because I was in IP unreachable, sorry.

Thank you, Roc.
I checked-in the patch.

-> FIXED