357616 - Remove remaining traces of nsIPref from widget/

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Even after bug 281298, there are still a few occurrences of nsIPref in widget.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 243125 [details] [diff] [review]
patch

+        nsCOMPtr<nsIObserver> obs(new Debug_PrefObserver());
         // Register callbacks for when these change
-        prefs->RegisterCallback(debug_PrefValues[i].name,
-                    debug_PrefChangedCallback,
-                    NULL);
+        prefs->AddObserver(debug_PrefValues[i].name, obs, PR_FALSE);

Fix OOM and simplify by writing
  nsIObserver* obs = new Debug_PrefObserver();
  if (obs) {
    prefs->AddObserver(debug_PrefValues[i].name, obs, PR_FALSE);
  }

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I suppose you need to keep obs an nsCOMPtr. But do check for OOM

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

check for OOM and move observer creation out of the for loop.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on trunk