Closed
Bug 357773
Opened 19 years ago
Closed 19 years ago
Fix bookmark warnings
Categories
(Camino Graveyard :: Bookmarks, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.1)
Attachments
(1 file)
|
5.74 KB,
patch
|
jaas
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
Warnings are not delicious delicacies.
|
Assignee | |
Comment 1•19 years ago
|
||
In case you are wondering, I use the (Foo *) style in KindaSmartFolderManager because it's the prevailing style there.
Attachment #243300 -
Flags: review?(joshmoz)
Comment on attachment 243300 [details] [diff] [review]
fixes
Casts are inconsistent in this way:
1) (Foo*)bar
2) (Foo *)bar
I prefer #1 for easy reading.
In your context there are things like this:
while ((curItem = [bookmarksEnum nextObject]))
{
Maybe you could fix the bracing to be on the same line as the test on checkin.
Attachment #243300 -
Flags: review?(joshmoz) → review+
Oops, I didn't read comment #1 before writing my review comments.
|
|
Assignee | |
Updated•19 years ago
|
Attachment #243300 -
Flags: superreview?(mikepinkerton)
|
||
Comment 4•19 years ago
|
||
Comment on attachment 243300 [details] [diff] [review]
fixes
rs=pink
Attachment #243300 -
Flags: superreview?(mikepinkerton) → superreview+
Whiteboard: [needs checkin]
|
||
Comment 5•19 years ago
|
||
Checked in on 1.8branch and trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
|
|
||
Updated•19 years ago
|
Keywords: fixed1.8.1.1
|
|
||
Updated•19 years ago
|
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•