357901 - submission 'post' to file doesn't work

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

If the form author specifies submission with @method="post" but uses a @action that is a local file, then we'll generate a xforms-submit-error.  This is because we assume that if the method type is post that the channel will be a nsIHttpChannel and bow out if it isn't.  Since other xforms processors don't generate an error with this scenario, I assume we are behaving incorrectly?

I talked to Jonas about it and he didn't think that there would be a security problem or anything if we treated POST like GET for all other protocols other than HTTP, which seems to be what XSmiles and formsPlayer do.

So should we do that or should we do the submission error like we do now and just put a better error in the Error Console?

Comment 1

[aaronr]

Attachment: testcase

Comment 2

[aaronr]

started a thread in the WG mailing list (http://lists.w3.org/Archives/Public/www-forms/2007Feb/0086.html).  Looks like it is non-normative (per Leigh's reply), so we can basically do what we like.  Unless we get some more feedback from the thread, I'd say we adopt formsPlayer's and XSmile's stance for replace="all" at least.  But should we continue to throw an error on replace="instance"?

Comment 3

[Leigh L. Klotz, Jr.]

Might give this one a day or two to see if anybody disagrees with me.

Comment 4

[aaronr]

Attachment: patch

Comment 5

[aaronr]

Comment on attachment 255950 [details] [diff] [review]
patch

fixing bug by allowing "post" with file protocol when replace="all" or "none".  We'll put a warning in the error console for all other non-http protocols and when file is used with replace="instance".  And in the warning cases, a xforms-submit-error event will still be sent as happened before this patch.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 255950 [details] [diff] [review]
patch



>+  if (mFormat & METHOD_POST)
>+  {

if (mFormat & METHOD_POST) {

Comment 7

[aaronr]

Attachment: patch2

fixes smaug's comment

Comment 8

[aaronr]

checked into trunk

Comment 9

[aaronr]

checked into 1.8 branch on 2007-04-12
checked into 1.8.0 branch on 2007-04-16