358183 - XML equality does not compare all attributes

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

The current implementation of XML equality in jsxml.c, XMLEquality function, can compares as equals XML elements with different set of attributes as the following example demonstrates:

@callisto~/m/trunk/mozilla/js/src> cat ~/m/files/y.js
var x = <a b="1"/>;
var y = <a b="1" c="2"/>;
if (x == y)
  throw "XML equality does not compare all attributes."

@callisto~/m/trunk/mozilla/js/src> ./Linux_All_DBG.OBJ/js ~/m/files/y.js
uncaught exception: XML equality does not compare all attributes.

Comment 1

[Igor Bukanov]

Scheduling fix for JS1.7. 

Comment 2

[Igor Bukanov]

Attachment: Fix v1

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 243719 [details] [diff] [review]
Fix v1

D'oh, my blunder -- nice fix, thanks.

/be

Comment 4

[Igor Bukanov]

I committed the patch from comment 2 to the trunk:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.134; previous revision: 3.133
done

Comment 5

[Igor Bukanov]

I suggest to apply this to 1.8.0 branch as well.

Comment 6

[Bob Clary [:bc] (inactive)]

Checking in 9.1.1.9.js;
/cvsroot/mozilla/js/tests/e4x/Types/9.1.1.9.js,v  <--  9.1.1.9.js
new revisio

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20061028 windows/linux

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 243719 [details] [diff] [review]
Fix v1

approved for 1.8/1.8.0 branches, a=dveditz for drivers

Comment 9

[Igor Bukanov]

I committed the patch from comment 2 to MOZILLA_1_8_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.56; previous revision: 3.50.2.55
done

Comment 10

[Igor Bukanov]

Attachment: Fix v1 for 1.8.0

The trunk patch does not applies as is due to the lack of js_EqualString on the branch that the trunk code uses hence a trivial port. 

Here is a diff with v1:

 diff  /home/igor/s/XMLEquality.patch /home/igor/s/XMLEquality-1.8.0.patch
4,8c4,8
< retrieving revision 3.133
< diff -U7 -p -r3.133 jsxml.c
< --- jsxml.c	26 Oct 2006 13:36:16 -0000	3.133
< +++ jsxml.c	26 Oct 2006 22:36:41 -0000
< @@ -3660,29 +3660,27 @@ retry:
---
> retrieving revision 3.50.2.15.2.26
> diff -U7 -p -r3.50.2.15.2.26 jsxml.c
> --- jsxml.c	7 Nov 2006 20:28:23 -0000	3.50.2.15.2.26
> +++ jsxml.c	9 Nov 2006 20:13:45 -0000
> @@ -3634,29 +3634,27 @@ retry:
29c29
<                  *bp = js_EqualStrings(attr->xml_value, vattr->xml_value);
---
>                  *bp = !js_CompareStrings(attr->xml_value, vattr->xml_value);

Diff finished at Thu Nov  9 21:14:09

Comment 11

[Daniel Veditz [:dveditz]]

Comment on attachment 245131 [details] [diff] [review]
Fix v1 for 1.8.0

approved 1.8.0 branch, a=dveditz

Comment 12

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.1.1 20061109 windows/linux/mac*

Comment 13

[Igor Bukanov]

I committed the patch from comment 10 to MOZILLA_1_8_0_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.15.2.27; previous revision: 3.50.2.15.2.26
done

Comment 14

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.0.9 20061111 windows/linux/mac*