358228 - tr_install.pl: tr_AddGroup() is broken on PostgreSQL

Status: RESOLVED FIXED

(Testopia :: General, defect)

Description

[tlast]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060413 Red Hat/1.0.8-1.4.1 Firefox/1.0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060413 Red Hat/1.0.8-1.4.1 Firefox/1.0.8

in sub tr_AddGroup, 

  my $sth = $dbh->prepare('INSERT INTO groups
-                          (name, description, userregexp, isbuggroup)
-                          VALUES (?, ?, ?, ?)');
-  $sth->execute($name, $desc, '', 0);
+  $sth = $dbh->prepare('INSERT INTO groups
+                          (name, description, userregexp, isbuggroup, last_changed)
+                          VALUES (?, ?, ?, ?, NOW())');
+  $sth->execute($name, $desc, "''", 0);




Reproducible: Always

Comment 1

[tlast]

Install will fail at "Adding group name" due to:

  last_changed field being null
  userregexp being ''
  and postgres has no "last_insert_id()"

Comment 2

[Vance Baarda]

Attachment: patch version 1

Picked up fixes from checksetup.pl:AddGroup()
Simplified GroupDoesExist() down to one line.

BTW, this statement will not work with mysql:
    $sth->execute($name, $desc, "''", 0);
Instead, we use this:
    $sth->execute($name, $desc, "", 0);

Comment 3

[Greg Hendricks]

Comment on attachment 243836 [details] [diff] [review]
patch version 1

>-  return $id;
>+  return $dbh->selectrow_array("SELECT COUNT(*) FROM groups WHERE name='$name'");
> }

Is there a reason why you are not using placeholders here?

Comment 4

[Vance Baarda]

I guess I was looking at a bad example. :-) Bugzilla still contains several SELECT COUNT statements that look like this.

I'll fix it.

Comment 5

[Vance Baarda]

Attachment: patch version 2

Use placeholder in GroupDoesExist()

Comment 6

[Vance Baarda]

r2335 | vrb | 2006-10-27 14:57:24 -0600 (Fri, 27 Oct 2006) | 4 lines
Changed paths:
   M /trunk/tr_install.pl

Use placeholder in GroupDoesExist()

Comment 7

[Greg Hendricks]

    Checking in tr_install.pl;
    /cvsroot/mozilla/webtools/testopia/tr_install.pl,v  <--  tr_install.pl
    new revision: 1.9; previous revision: 1.8
    done

Comment 8

[JK]

Many thanks - installation succeeded!