358368 - changing 'paragraph mode' discards attributes

Status: REOPENED

(Core :: DOM: Editor, defect)

Description

[Eyal Rozenberg]

If you change the paragraph mode in a composed message, e.g. from P to H1, then the attributes of the <p> element (dir, align, style, class, etc.) are not maintained. While one may debate whether all of these need be maintained, certainly the default should be 'maintain' rather than 'discard'.

This causes, in particular,
http://bugzilla.mozdev.org/show_bug.cgi?id=13294

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #1, ready for review, tested

Comment 2

[Pierre Saslawsky]

I'm completely stepping out of my turf here but can't you use 'aCloneAttributes' in ReplaceContainer()?

In that case, the patch would be just one line: replace 
    ... mHTMLEditor->ReplaceContainer(...);
with
    ... mHTMLEditor->ReplaceContainer(..., nsnull, nsnull, PR_TRUE);

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 243792 [details] [diff] [review]
fix #1, ready for review, tested

(In reply to comment #2)
> I'm completely stepping out of my turf here but can't you use
> 'aCloneAttributes' in ReplaceContainer()?
> 
> In that case, the patch would be just one line: replace 
>     ... mHTMLEditor->ReplaceContainer(...);
> with
>     ... mHTMLEditor->ReplaceContainer(..., nsnull, nsnull, PR_TRUE);

BWAHAHA !!! Pierre, that's certainly the first time I laugh so much reading a technical comment. Thanks a zillion for the good catch.

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

neil said in IRC

  <NeilAway> glazou: yes, you can take that as r+sr

checked in (trunk)

Comment 6

[Eyal Rozenberg]

Bug still manifests with SM trunk 2008-07-21.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.