358523 - use better transparent icons in Search Bar for some engine

Status: RESOLVED DUPLICATE of bug 421613

(Firefox :: Search, enhancement)

Description

[Bernhard Walzl]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1) Gecko/20061010 Firefox/2.0

All images are transparent and you do not see the white background. The ebay image has the white background and isn't transparent. You cann see this, when you choose ebay in the Searchbar in the right top corner.
The Amazon-Image has also some white pixel.

Reproducible: Always

Steps to Reproduce:
1. Click on the Icon of the Searchbar.
2. choose ebay but dont click. now the row is darker and you see the white background :)
3. unnecessary

Actual Results:  
You can see the white background of the icon :)

Expected Results:  
A nice gif with a transparent background should be added.

about:buildconfig

Build platform
target
i586-pc-msvc

Build tools
Compiler 	Version 	Compiler flags
$(CYGWIN_WRAPPER) cl 	12.00.8804 	-TC -nologo -W3 -Gy -Fd$(PDBFILE)
$(CYGWIN_WRAPPER) cl 	12.00.8804 	-TP -nologo -W3 -Gy -Fd$(PDBFILE)

Configure arguments
--enable-application=browser --enable-update-channel=release --enable-official-branding --enable-optimize --disable-debug --disable-tests --enable-static --disable-shared --enable-svg --enable-canvas --enable-update-packaging

Comment 1

[Steve England [:stevee]]

Reporter, do you still see this problem with the latest Firefox 2? If not, can you please close this bug as WORKSFORME. Thanks!

Comment 2

[Bernhard Walzl]

Yes, this Bug is also visible in Firefox 2.

Comment 3

[Marco Bonardo [:mak]]

don't know if this is actually a real bug report, it is asking to change search engine icons to use better "trasparent" ones (yahoo one is transparent while ebay one is not)

it sounds more like an enhancement, updating title...
maybe this should be addressed by engine owner

Comment 4

[Michael Schonfeld]

im getting the same deal with todays tree on my leopard!  some of the icons are simply low quality..

Comment 5

[:Gavin Sharp [email: [e-mail]]]

The search engine icons haven't changed since this bug was filed, so if you're seeing something that changed only recently you should file a new bug.

Comment 6

[Michael Schonfeld]

That's exactly the problem.  Up until now, that the theme's search bar background was white, this was not an issue.  But now, that Mac's default theme is the proto one, and the search bar's background is gray - the transparency had become a real issue. Am I not understanding something?

I'll attached some pictures of the issue I am referring to.

Comment 7

[Michael Schonfeld]

Attachment: screenshot #1

Comment 8

[Michael Schonfeld]

Attachment: screenshot #2

Comment 9

[Michael Schonfeld]

Attachment: screenshot #3

Comment 10

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> That's exactly the problem.  Up until now, that the theme's search bar
> background was white, this was not an issue.

Sure, that's the case now, but that wasn't the case in 2006 when this bug was filed. Sounds like you're assuming the original reporter was complaining about the same problem you are - hard to tell because he didn't give any details about how he was noticing the lack of transparency.

Anyhow, I'd guess it's probably up to the engines to use a better icon. Perhaps we could check these site's favicons, if they exist and are the same image as the existing icons?

Comment 11

[Bernhard Walzl]

Hallo!

Looks like I needed to wait a year until my concern got answered :)

Yes, it is the same case! It is exactly what "Michael Schonfeld" showed in the screenshots!
It just dont look nice, when there are white dots in the amazon-logo or this white box around Wikipedia or ebay.

Comment 12

[Michael Schonfeld]

Attachment: v1

Comment 13

[Michael Schonfeld]

To sum up the patch:
Amazon - fixed.  New icon form amazon.
CC - fixed.  Old icon, transparent background.
eBay - fixed.  Old icon, transparent background.
Wikipedia - fixed, but still crappy is some instances. I wish they would just release a transparent version of their favicon!

Comment 14

[Mike Connor [:mconnor]]

Would be nice to have, but we need to use the actual icons the sites use, we don't own the copyright on the favicon and my IANAL brain says this is creating derivative works in the cases where we're hacking it ourselves.

Kev, can you see if we can get better icons for the that aren't so great now?

Comment 15

[Michael Schonfeld]

Attachment: v1.2

If its simply matter of legality, then we can just use the new Amazon & eBay favicons.  Both are a great improvement to the previous ones. We'll hold out with the Wikipedia & CC ones until they put out a new favicon.

I'll shoot up a couple of screenshots of how the new eBay & Amazon icons look.

Comment 16

[Michael Schonfeld]

Attachment: v1.3

disregard v1.2

Comment 17

[Michael Schonfeld]

Attachment: eBay favicon

Comment 18

[Michael Schonfeld]

Attachment: Amazon favicon

Comment 19

[Kev Needham [:kev]]

Attachment: eBay Favicon from eBay Marketing

eBay favicon from the eBay marketing team. We're just double-checking that we have permission to use, and I'll update the ticket when we have it. This favicon is similar to what's used on the website, but has the black pixel removed as well. Please review and let me know if it's acceptable.

I'm working on Amazon and CC, as well. The intent for Amazon will be to just use their current website favicon. Let me know if that's acceptable.

Comment 20

[Michael Schonfeld]

Hey Kev.. see if you could maybe get your hands a transparent backgrounded Wikipedia icon, it could be nice to have that one too.

Comment 21

[Kev Needham [:kev]]

Attachment: Proposed CC logo - for review only

Permission to use the attached icon for CC has been sent to Creative Commons for review and approval. Please review the icon (I believe it meets needs, but would appreciate additional eyeballs) and make sure it's appropriate. If changes are required, please let me know ASAP. 

I'll update the bug if/when we receive formal approval.

Comment 22

[Kev Needham [:kev]]

err... a REQUEST for permission to use the attached icon has been sent. I need a new brain.

Comment 23

[Kev Needham [:kev]]

Attachment: Approved CC Logo

Approved Creative Commons logo for inclusion for the search plugin attached. Sent from Alex Roberts at Creative Commons. Let me know if there are any questions.

Comment 24

[Kev Needham [:kev]]

Attachment: Approved Amazon Logo for Review

Attached is the approved logo from Amazon.com for inclusion for the search plugin. We have been asked to provide a mockup for approval, and I will create these mockups for Amazon and update the ticket when we have final approval.

Comment 25

[Mike Beltzner [:beltzner, not reading bugmail]]

This will be fixed on trunk by bug 421613 if you want to steal the same patch for branch ...

Comment 26

[:Gavin Sharp [email: [e-mail]]]

I'm not sure this is worth worrying about on the branch.