Disabled and checked menuitems should always have disabled checkmarks

VERIFIED FIXED in seamonkey1.1final

Status

SeaMonkey
General
--
minor
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

({fixed-seamonkey1.1})

unspecified
seamonkey1.1final
x86
All
fixed-seamonkey1.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

11 years ago
Spun-off from bug 345252. If you hover over a checked menuitem that is disabled you shouldn't see any hover effect on the checkmark.
(Assignee)

Comment 1

11 years ago
Hmm... I went ahead and did a patch, but then I looked at the tick/radio marks. They're the same for normal and disabled state (Modern and classic/win). Wouldn't it look odd if you just fix the css and not the icons?

Comment 2

11 years ago
I don't have Modern handy but I agree it's incorrect in Classic.

Still, changing the colour is easy enough.
(Assignee)

Comment 3

11 years ago
Created attachment 244479 [details] [diff] [review]
flip style rules

This should fix classic. I'll attach new icons in a few sec.
Assignee: general → stefanh
Status: NEW → ASSIGNED
Attachment #244479 - Flags: superreview?(neil)
Attachment #244479 - Flags: review?(neil)
(Assignee)

Comment 4

11 years ago
Created attachment 244480 [details]
New menu-check-disabled.gif
(Assignee)

Comment 5

11 years ago
Created attachment 244482 [details]
New menu-radio-disabled.gif
(Assignee)

Comment 6

11 years ago
Created attachment 244483 [details]
New menu-arrow-disabled.gif

I changed color of menu-arrow-disabled.gif (old one had a0a0a0). Note that the patch and the icons are not tested...
(Assignee)

Updated

11 years ago
Target Milestone: --- → seamonkey1.1final

Comment 7

11 years ago
(In reply to comment #6)
>I changed color of menu-arrow-disabled.gif (old one had a0a0a0).
Hmm, I found some of our disabled arrows use #999999 ...

Manuel, what's your preference?

Comment 8

11 years ago
Sigh, the so-called disabled check mark is black :-(

Updated

11 years ago
Attachment #244479 - Flags: superreview?(neil)
Attachment #244479 - Flags: superreview+
Attachment #244479 - Flags: review?(neil)
Attachment #244479 - Flags: review+

Comment 9

11 years ago
So, we currently have:
generic arrow images: disabled colour #999999
checkbox/radiobutton images: disabled colour #808080
menu right arrow: disabled colour #a0a0a0
menu check/radio images: disabled colour #000000
So the menu images are at least definitely wrong ;-)
(Assignee)

Comment 10

11 years ago
(In reply to comment #9)
> So, we currently have:
> generic arrow images: disabled colour #999999
> checkbox/radiobutton images: disabled colour #808080
> menu right arrow: disabled colour #a0a0a0
> menu check/radio images: disabled colour #000000
> So the menu images are at least definitely wrong ;-)
> 
Do you want to go with the 3 disabled images with colour #808080 that I've attached?
(Assignee)

Comment 11

11 years ago
Comment on attachment 244479 [details] [diff] [review]
flip style rules

This is just a style-rule flip that makes us use the css for disabled checkmarks when you hover over a disabled and checked menuitem. We need the images as well (if we want the change to mean anything).
Attachment #244479 - Flags: approval-seamonkey1.1?

Comment 12

11 years ago
Comment on attachment 244479 [details] [diff] [review]
flip style rules

first-a=me for SeaMonkey 1.1
Has this baked on trunk?
(Assignee)

Comment 14

11 years ago
(In reply to comment #13)
> Has this baked on trunk?

No it hasn't - I forgot to ask someone to check it in :-/
Landing this on trunk so I can grant approval for branch soon.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Checked in new images too.
Attachment #244479 - Flags: approval-seamonkey1.1? → approval-seamonkey1.1+
(Assignee)

Comment 17

11 years ago
Chris, can you land it on branch please?
Verified on trunk.
Checked in on branch.
Status: RESOLVED → VERIFIED
Keywords: fixed-seamonkey1.1
You need to log in before you can comment on or make changes to this bug.