358686 - pop-up blocker message text is confusing

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[J Luh]

Camino 1.1a1

The pop-up blocker message "A pop-up has been blocked for this website" is confusing--the pop-up has been blocked for the user, not for the Web site. It might be less confusing to say just "A pop-up has been blocked."

Also, perhaps it should say "pop-up window" (as it does in the preferences dialog) instead of just "pop-up."

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If we do anything here, we need to do it by 1.1b1 at the latest.

"Camino has blocked a pop-up window [on|from] this website."

Comment 2

[J Luh]

I think the text suggested in comment 1 is good.

Comment 3

[Stuart Morgan]

I don't think adding 'window' is worthwhile, as it makes the text longer without adding any real clarity.

Comment 4

[Stuart Morgan]

We should also think about s/website/page/ since we've moved other text to say page.

Pink, this just text in a nib, so it doesn't really need a patch. What say you to:
"Camino has blocked a pop-up from this page."
(or alternately, "Camino has blocked a pop-up from this website")?

Comment 5

[Mike Pinkerton (not reading bugmail)]

that's fine, just be consistent.

Comment 6

[Stuart Morgan]

Checked in as "Camino has blocked a pop-up from this website." (page didn't quite feel right in that context somehow when I tried it) on trunk and MOZILLA_1_8_BRANCH.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Clearing since this landed well in advance of b1....

Comment 8

[J Luh]

I'm still getting the old text ("A pop-up has been blocked for this website") with Camino 1.1.a2. Is the new text supposed to appear in that build?

Comment 9

[Stuart Morgan]

The nib changes got stomped (probably by the wrapping stuff), thanks for noticing.  Re-checked in.