358750 - autorepeatbutton seem always clickable even when disabled

Status: NEW

(Toolkit :: UI Widgets, defect)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

even if an autorepeatbutton is disabled, its styles change when the
mouse pointer hovers over it. In the attached URL, the rule

autorepeatbutton:hover,
autorepeatbutton:hover:active
  {
    margin                : 1px;
    border                : 1px inset ThreeDFace;
    padding-top: 2px;
    padding-bottom: 1px;
    -moz-padding-start: 2px;
    -moz-padding-end: 1px;
  }

should be

autorepeatbutton:not([disabled]):hover,
autorepeatbutton:not([disabled]):hover:active
  {
    margin                : 1px;
    border                : 1px inset ThreeDFace;
    padding-top: 2px;
    padding-bottom: 1px;
    -moz-padding-start: 2px;
    -moz-padding-end: 1px;
  }

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #1

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 244087 [details] [diff] [review]
fix #1

>Index: scrollbox.css

>-autorepeatbutton:hover,
>-autorepeatbutton:hover:active
>+autorepeatbutton:not([disabled]):hover,
>+autorepeatbutton:not([disabled]):hover:active

Use :not([disabled="true"]) instead to match the other similar rules in the file. r=me with that.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.