Closed Bug 358799 Opened 19 years ago Closed 16 years ago

The <marquee> isn't working very well at this site

Categories

(Core :: DOM: HTML Parser, defect)

Product:
Core
Component:
DOM: HTML Parser
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ssj4maiko, Unassigned)

References

(
URL
)

Details

(Keywords: testcase, Whiteboard: [fixed by the HTML5 parser])

Attachments

(2 files)

testcase, attached to bug
201 bytes, text/html
Details
patch
930 bytes, patch
mrbkap
: review-
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7 I've created an forum, and me and some friends have made everything perfect.But every time that I see, the "Rakuen News" Board don't slide. Thought that it could be an problem at the code, but it works perfectly at IE. As I don't like IE (just to don't say other words), could you fix this little problem? Thanks Reproducible: Always Steps to Reproduce: 1. Just enter Actual Results: The "Rakuen News" Board don't slide like the other two. Expected Results: It should slide, like when I enter by IE
This is a parser issue, see: http://software.hixie.ch/utilities/js/live-dom-viewer/?%3Cbody%3E%0A%3Cdiv%3E%0A%3Cmarquee%3E%0A%3C/div%3E%0AThis%20text%20should%20scroll%0A%3C/marquee%3E%0A%3C/body%3E In IE7, I get this DOM tree: HTML HEAD TITLE BODY DIV MARQUEE DIV #text: This text should scroll In current trunk Mozilla builds, I get this DOM tree: * HTML o HEAD o BODY + #text: + DIV # #text: # MARQUEE * #text: + #text: This text should scroll So maybe Mozilla should change the parser to reflect more how IE7 handles this or else this is a tech evangelism issue, because removing the stray </center> tag fixes the problem
Assignee: nobody → mrbkap
Component: General → HTML: Parser
Keywords: testcase
Product: Firefox → Core
QA Contact: general → parser
Version: unspecified → Trunk
(In reply to comment #1) > So maybe Mozilla should change the parser to reflect more how IE7 handles this > or else this is a tech evangelism issue, because removing the stray </center> > tag fixes the problem You mean </div>?
(In reply to comment #3) > You mean </div>? Yes, in the testcase it is a </div>, on the site there is a stray </center>.
Thanks everyone. I don't know who had done that table, but whe I remade that, it worked better, and as we upgraded the forum, we won't have anymore troubles with that. But thanks anyway ^^
I'm lost! I am not a developer and don't have the knowledge and expertise needed to even understand most of these notes, let alone implement whatever fixes are noted herein. I just create simple HTML pages, and by the grace of God, they usually do what they're supposed to. All I know is that my pages aren't displaying scrolling marquees I created. They work in my HTML editor and they work in IE7, but not in Firefox. As more and more people are becoming disillusioned with IE and are switching over to Firefox, I can't help but wonder how many users are wondering why my pages have a large blank space at the top. Here's the code I used to use: <P><BR><BR><Marquee BEHAVIOR="Scroll" WIDTH=80% loop="10"><FONT FACE="monotype corsiva, brush script" SIZE="5">Text that's supposed to scroll.... </MARQUEE> And here's the new code I tried after reading these comments: <body> <div> <Marquee> </div> <FONT FACE="monotype corsiva, brush script" SIZE="5">Text that's supposed to scroll.... </marquee> </body> This code resulted in ALL my text displaying as one large block of text. NOT what I wanted.... And FYI, I tried it both with and without the </div> tag. Help(!!) anyone....
(In reply to comment #6) > This code resulted in ALL my text displaying as one large block of text. NOT > what I wanted.... And FYI, I tried it both with and without the </div> tag. It just works fine for me after removing the </div> tag.
Attached patch patch — — Splinter Review
This fixes it, but I get this resulting dom: <div> <marquee> </marquee></div> <marquee>This text should scroll </marquee> In IE7 I get this resulting dom: <DIV> <MARQUEE> <DIV></DIV>This text should scroll</MARQUEE></DIV> I think it's better to follow IE7's behavior, is there a way to do that?
Attachment #274766 - Flags: review?(mrbkap)
Comment on attachment 274766 [details] [diff] [review] patch I don't think we want to do this. The way to fix this with the current parser would be to make </div> not be able to close <marquee>, but I'm not sure what the cleanest way to do that would be. Switching to an HTML5 parser would fix this problem (see http://parsetree.validator.nu/?parser=html5&content=%3Cbody%3E%3Cdiv%3E%3Cmarquee%3E%3C%2Fdiv%3EThis+text+should+scroll%3C%2Fmarquee%3E%3C%2Fbody%3E&submit=Print+Tree)
Attachment #274766 - Flags: review?(mrbkap) → review-
Assignee: mrbkap → nobody
(In reply to comment #9) > Switching to an HTML5 parser would fix > this problem Indeed. :-)
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by the HTML5 parser]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: