Closed Bug 358831 Opened 18 years ago Closed 18 years ago

[history sidebar panel] right mouse button click should not expand / collapse item

Categories

(Firefox :: Bookmarks & History, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 alpha1

People

(Reporter: moco, Assigned: moco)

References

()

Details

right mouse button click should not expand / collapse item in history sidebar


the culprit is:

137   var modifKey = aEvent.shiftKey || aEvent.ctrlKey || aEvent.altKey || 
138                  aEvent.metaKey  || aEvent.button == 1;

http://lxr.mozilla.org/seamonkey/source/browser/components/history/content/history.js#138

I think it should be aEvent.button != 0;

This way, if button == 2, we do the right thing.

I've got the fix for this in the new history-panel.xul, see bug #356487

I couldn't find a bug on this, but I'm sure one must exist.  (gavin / ispiked, does it ring any bells?)
fixed.

if we wanted to back port this to Fx 2.0.0.1, it would to port the fix to http://lxr.mozilla.org/mozilla1.8/source/browser/components/history/content/history.js#138
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 alpha1
Component: History → Bookmarks & History
QA Contact: history → bookmarks
You need to log in before you can comment on or make changes to this bug.