358831 - [history sidebar panel] right mouse button click should not expand / collapse item

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

right mouse button click should not expand / collapse item in history sidebar


the culprit is:

137   var modifKey = aEvent.shiftKey || aEvent.ctrlKey || aEvent.altKey || 
138                  aEvent.metaKey  || aEvent.button == 1;

http://lxr.mozilla.org/seamonkey/source/browser/components/history/content/history.js#138

I think it should be aEvent.button != 0;

This way, if button == 2, we do the right thing.

I've got the fix for this in the new history-panel.xul, see bug #356487

I couldn't find a bug on this, but I'm sure one must exist.  (gavin / ispiked, does it ring any bells?)

Comment 1

[(not reading, please use [e-mail] instead)]

fixed.

if we wanted to back port this to Fx 2.0.0.1, it would to port the fix to http://lxr.mozilla.org/mozilla1.8/source/browser/components/history/content/history.js#138