Closed Bug 358891 Opened 13 years ago Closed 13 years ago

Firefox doesn't remember the search engine with non-ascii characters as its selected engine

Categories

(Firefox :: Search, defect)

2.0 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 2

People

(Reporter: kohei, Assigned: kohei)

Details

(Keywords: verified1.8.1.1)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: N/A

The value of 'browser.search.selectedEngine' pref should be saved as complex value.
I'll make a patch.


Reproducible: Always

Steps to Reproduce:
1. Select new search engine with non-ascii characters from search bar.
2. Restart Firefox.

Actual Results:  
Selected search engine is now the default engine of Firefox.

Expected Results:  
Selected search engine is the engine i chose.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch patch v1Splinter Review
This works for me.
We at Mozilla Japan request this fix for blocking1.8.1.1.
Flags: blocking1.8.1.1?
Assignee: nobody → kohei.yoshino.bugs
Target Milestone: --- → Firefox 2
Version: unspecified → 2.0 Branch
The search plugin of 楽天市場 (Rakuten shopping mall) that comes with ja locale.
You can test with it.
Thanks for the patch, and for finding my mistake :(. I landed this fix on the trunk, please verify.

mozilla/browser/components/search/nsSearchService.js 	1.88
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Looks good on the trunk. Thank you!
Status: RESOLVED → VERIFIED
Flags: blocking1.8.1.1? → blocking1.8.1.1+
Comment on attachment 244198 [details] [diff] [review]
patch v1

Approved for 1.8.1 branch, a=jay for drivers.  Please land asap.  Thanks!
Attachment #244198 - Flags: approval1.8.1.1? → approval1.8.1.1+
mozilla/browser/components/search/nsSearchService.js 	1.1.2.72
Keywords: fixed1.8.1.1
Kohei:  Could you please verify this on the 1.8 branch as well?  Please test with  the latest -mozilla1.8 build and replace "fixed1.8.1.1" with "verified1.8.1.1" if the search engine selection works as expected.  Thanks!
Verified. Thanks!
You need to log in before you can comment on or make changes to this bug.