User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0 Build Identifier: N/A The value of 'browser.search.selectedEngine' pref should be saved as complex value. I'll make a patch. Reproducible: Always Steps to Reproduce: 1. Select new search engine with non-ascii characters from search bar. 2. Restart Firefox. Actual Results: Selected search engine is now the default engine of Firefox. Expected Results: Selected search engine is the engine i chose.
Status: UNCONFIRMED → NEW
Ever confirmed: true
We at Mozilla Japan request this fix for blocking188.8.131.52.
Attachment #244198 - Flags: review+
Assignee: nobody → kohei.yoshino.bugs
Target Milestone: --- → Firefox 2
Version: unspecified → 2.0 Branch
Created attachment 244201 [details] search engine with non-ascii characters The search plugin of 楽天市場 (Rakuten shopping mall) that comes with ja locale. You can test with it.
Thanks for the patch, and for finding my mistake :(. I landed this fix on the trunk, please verify. mozilla/browser/components/search/nsSearchService.js 1.88
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Attachment #244198 - Flags: approval184.108.40.206?
Looks good on the trunk. Thank you!
Status: RESOLVED → VERIFIED
Comment on attachment 244198 [details] [diff] [review] patch v1 Approved for 1.8.1 branch, a=jay for drivers. Please land asap. Thanks!
Attachment #244198 - Flags: approval220.127.116.11? → approval18.104.22.168+
Kohei: Could you please verify this on the 1.8 branch as well? Please test with the latest -mozilla1.8 build and replace "fixed22.214.171.124" with "verified126.96.36.199" if the search engine selection works as expected. Thanks!
Keywords: fixed188.8.131.52 → verified184.108.40.206
You need to log in before you can comment on or make changes to this bug.