358909 - Message filter "Age" only allows positive values

Status: RESOLVED FIXED

(MailNews Core :: Search, enhancement)

Description

[Michael Letzgus]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.1) Gecko/20061010 Firefox/2.0

The message filter "Age" only allows positive values.

Negative values would be nice to deal with junk mail sent with a wrong date from the future.



Alternative:
Add "today"-type date to the "date"-filter.

Reproducible: Always

Steps to Reproduce:
nothing at all

Comment 1

[Magnus Melin [:mkmelin]]

-> new, valid rfe.

Comment 2

[Magnus Melin [:mkmelin]]

*** Bug 356026 has been marked as a duplicate of this bug. ***

Comment 3

[Magnus Melin [:mkmelin]]

Taking.

Comment 4

[WADA:World Anti-bad-Duping Agency]

DUP of Bug 174294, isn't it?

Comment 5

[Magnus Melin [:mkmelin]]

Effectively, yes... but this bug is so uncluttered;)

Comment 6

[WADA:World Anti-bad-Duping Agency]

I see. Setting dependency.

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

This makes search/filters accept negative age. So age > -3 means more than three days in the future. Age < -3 means date is before three days in the future.

(Removing the headersString variable as it wasn't used.)

Comment 8

[David :Bienvenu]

Comment on attachment 269691 [details] [diff] [review]
proposed fix

nice, thx, Magnus.

Comment 9

[David :Bienvenu]

oh, you should gen a new uuid for the nsIMsgSearchValue

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: proposed fix (as checked in)

Fix as checked in, with new uuid

Comment 11

[Magnus Melin [:mkmelin]]

Checking in base/search/public/nsIMsgSearchValue.idl;
/cvsroot/mozilla/mailnews/base/search/public/nsIMsgSearchValue.idl,v  <--  nsIMsgSearchValue.idl
new revision: 1.10; previous revision: 1.9
done
Checking in base/search/public/nsMsgSearchCore.idl;
/cvsroot/mozilla/mailnews/base/search/public/nsMsgSearchCore.idl,v  <--  nsMsgSearchCore.idl
new revision: 1.31; previous revision: 1.30
done
Checking in base/search/src/nsMsgSearchAdapter.cpp;
/cvsroot/mozilla/mailnews/base/search/src/nsMsgSearchAdapter.cpp,v  <--  nsMsgSearchAdapter.cpp
new revision: 1.92; previous revision: 1.91
done
Checking in base/search/src/nsMsgSearchTerm.cpp;
/cvsroot/mozilla/mailnews/base/search/src/nsMsgSearchTerm.cpp,v  <--  nsMsgSearchTerm.cpp
new revision: 1.143; previous revision: 1.142
done
Checking in base/search/src/nsMsgSearchValue.cpp;
/cvsroot/mozilla/mailnews/base/search/src/nsMsgSearchValue.cpp,v  <--  nsMsgSearchValue.cpp
new revision: 1.28; previous revision: 1.27
done

->FIXED

Comment 13

[Peva]

Is this fix in TB-2?  If not, will it be incorporated into it?

Sorry if this is not the right place to ask this.

Comment 14

[Magnus Melin [:mkmelin]]

No sorry, you'll have to wait for tb3.