358926 - crash [@ EmbedPrivate::Realize]

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Chris Lahey]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.2) Gecko/20060419 Fedora/1.5.0.2-1.2.fc5 Firefox/1.5.0.2 pango-text
Build Identifier: firefox package as shipped with Fedora Core 6

I've looked into it and mWindow->Init(this) is returning NS_ERROR_FAILURE, which is being ignored.  mWindow->Init(this) is failing because do_CreateInstance(NS_WEBBROWSER_CONTRACTID); is returning a null pointer.  It looks as if this is because NS_WEBBROWSER_CONTRACTID ("@mozilla.org/embedding/browser/nsWebBrowser;1") isn't in the component registry.  Is there some change to the way I need to initialize gtkmozembed?

Reproducible: Always

Steps to Reproduce:
1. Install FC6
2. Download and run democracyplayer as described at https://develop.participatoryculture.org/projects/democracy/wiki/GTKX11BuildDocs
Actual Results:  
App crashes.  After debugging, have traced problem to do_CreateInstance.

Comment 1

[Adam Guthrie]

Maybe you should report this to the democracy guys, too?

Comment 2

[Chris Lahey]

I am one of the democracy guys.  I'm trying to figure out how to change democracy to fix it.

Comment 3

[John Dennis]

Looks like this is the same bug as reported here:

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205499

Comment 4

[Chris Lahey]

It is the same thing, I think.  It's explored further here, I think.

I've explored it some more.  On FC6, we fixed it by calling set_comp_path.  However, with newer gtks like on ubuntu or gentoo, a very similar crash occurs unless you set LD_LIBRARY_PATH to the mozilla path.

Comment 5

[timeless]

i'll gladly r+ the patch to add the null check, please post it, or wait for me to do all the other work i have to do to catch up.

but the null check won't solve your problem. gecko embedding requirements include someone telling gecko where to find the libraries they want used. classically this is handled by run-mozilla.sh.

Comment 6

[Benjamin Smedberg]

What are you trying to embed, and what linkage strategy are you using?

Comment 7

[timeless]

Attachment: look before leaping

Comment 8

[timeless]

Comment on attachment 246659 [details] [diff] [review]
look before leaping

this is nuts. I'm something of a module owner, and even I can't get reviews.

I'm not going to try again.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 246659 [details] [diff] [review]
look before leaping

Sure.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 246659 [details] [diff] [review]
look before leaping

a=bzbarsky

Comment 11

[timeless]

mozilla/embedding/browser/gtk/src/EmbedPrivate.cpp 	1.65 <[e-mail]> 2006-12-03 20:06

joke's on me. sorry all.