Closed Bug 358931 Opened 18 years ago Closed 18 years ago

xpcom/reflect/xptcall/src/md/unix/ built without _IMPL_NS_COM

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(1 file)

patch
1.08 KB, patch
benjamin
: review+
Details | Diff | Splinter Review 
xpcom/reflect/xptcall/src/md/unix/Makefile.in does not define _IMPL_NS_COM .  This is a substantive problem for me on the 1.8 branch, where it also does not use MOZILLA_INTERNAL_API, but less of a problem on the trunk, where it does.  Defining _IMPL_NS_COM triggers different definitions of NS_COM_GLUE in nscore.h that affect __attribute__((visibility())) declarations.  (Either using MOZILLA_INTERNAL_API=1 or defining _IMPL_NS_COM will fix my errors building the 1.8 branch on FC6.)

It seems to me that this really should define _IMPL_NS_COM, and that this ought to be safe enough for the 1.8 branch (although anything in this directory carries some risk to obscure ports).
Attached patch patch — — Splinter Review 

        Attachment #244219 -
        Flags: review?(benjamin)

    
  

        Attachment #244219 -
        Flags: review?(benjamin) → review+

    
    

    
  
Checked in to trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: