358965 - XMLList.prototype.contains() no longer work

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

The fix for bug 354145 introduced a regression in XMLList.prototype.contains implementation in xml_contains() from jsxml.c. The C code always returns false for false results which silently breaks script execution.

For example, after
<><a/><b/></>.contains(<c/>);
the rest of the code is not executed.

I mark the bug as restricted as 354145 is.

Comment 1

[Igor Bukanov]

Attachment: Fix v1

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 244260 [details] [diff] [review]
Fix v1

I have to do a better job reviewing... air travel has taken its toll....

Please hook this up to go into js1.7src and 1.8.1.1 if it's a followup to a fix slated for those targets.

/be

Comment 3

[Igor Bukanov]

I committed the patch from comment 1 to the trunk: 

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.136; previous revision: 3.135
done

Comment 4

[Igor Bukanov]

Comment on attachment 244260 [details] [diff] [review]
Fix v1

This is a regression fix for the security fix.

Comment 5

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20061103 windows/linux

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 244260 [details] [diff] [review]
Fix v1

Approved for 1.8.0/1.8 branches, a=dveditz for drivers

Comment 7

[Igor Bukanov]

I committed the patch from comment 1 to MOZILLA_1_8_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.55; previous revision: 3.50.2.54
done

Comment 8

[Igor Bukanov]

I committed the patch from comment 1 to MOZILLA_1_8_0_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.15.2.26; previous revision: 3.50.2.15.2.25
done

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.0.9,1.8.1.1 20061108 windows/linux/mac*