Don't use yes/no for caret browsing dialog

NEW
Unassigned

Status

()

Toolkit
XUL Widgets
--
enhancement
11 years ago
6 years ago

People

(Reporter: Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com], Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/browser.xml#497

Maybe fewer people will enter it accidentally if it is "Enter caret browsing mode" or something else in place of "Yes", and if the default button were what is currently the "No" option.

(cc'ing some a11y people in case they disagree for some reason, and a toolkit person since they do the same thing)
CTho: Does this problem happen on current builds? If it does, please describe more clearly:

- version used (useragent)
- Reproducible? (Always, Sometimes, etc.)
- steps to reproduce
- actual result
- expected result
(In reply to comment #1)
> CTho: Does this problem happen on current builds? If it does, please describe
> more clearly:
> 
> - version used (useragent)

Doesn't matter.  20080319 though.

> - Reproducible? (Always, Sometimes, etc.)

Always.

> - steps to reproduce

Press F7

> - actual result

Dialog box warning user, "you're aboot to make your arrow keys not work.  continue? [yes] [no]", with yes as the default choice

> - expected result

Dialog box warning user, "you're about to make your arrow keys not work.  [make my arrow keys not work] [cancel]" either with cancel as default or one of those countdowns we use in other places where ignoring a dialog causes trouble (e.g. file downloads).
Hm. Hitting F7 gives me a dialog with the following text:

Pressing F7 turns Caret Browsing on or off. This feature places a moveable cursor in web pages, allowing you to select text with the keyboard. Do you want to turn Caret Browsing on?

[ ] Do not show me this dialog box again
                                                          [  No   ] [[ Yes ]]

This is with
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008041301 SeaMonkey/2.0a1pre

The text is different from what you're mentioning (I suppose that, depending on POV, it can be seen as clearer or as less clear) so I would say that version _does_ matter. However, it's still yes/no (but yes/no to "Enter caret browsing mode" which is what you wanted in comment #0) and it's still yes by default. I believe this is the correct default though, since <Enter> is the opposite of <Esc>, and <Esc> == "No" == "Cancel".
P.S. Hitting F7 when Caret Browsing is on, turns it off with no warning, which could be an accessibility problem. I guess this would be a different bug though.

Comment 5

10 years ago
People don't actually notice what the caret browsing dialog says even when it does come up. They hit F7 by accident and just dismiss the dialog and later wonder why pressing space bar to scroll doesn't work anymore. I've actually seen friends and relatives who had caret browsing on accidentally and didn't know.

That's why I think the F7 caret browsing mode should not persist between sessions. If you set it in the option panel it could persist. There was a bug for that and I can't find it right now.
Filter "spam" on "guifeatures-nobody-20080610".
Assignee: guifeatures → nobody
QA Contact: guifeatures

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
I have zero compassion for users (with "normal" vision & hearing) who see a strange dialog pop up and dismiss it without reading, not knowing what they do, especially in SeaMonkey, whose "targeted" userbase are supposed to have brains between their ears, not cottage cheese.

OTOH changing the "default behaviour" to set caret-browsing mode from F7, Enter to F7, Tab, Enter (while the other would do nothing) could be a major regression for e.g. blind people.

I suggest WONTFIX or even INVALID.
Whiteboard: [CLOSEME INVA/WONT?]

Comment 8

7 years ago
XPFE is dead. Code now lives in toolkit
Component: UI Design → XUL Widgets
Product: SeaMonkey → Toolkit
QA Contact: ui-design → xul.widgets
Hardware: x86 → All

Comment 9

7 years ago
This seems like two separate changes.  The change mentioned in the title of this bug report sounds very reasonable: rather than using "Yes" and "No", use clearer button labels such as "Turn on Caret Browsing" and "Cancel".  (Similar to the awesome change to make onbeforeunload use "Leave page" and "Stay on page".)  Separate from that, the original report and several comments also suggest changing the default in the dialog; that seems like a separate bug report.  I'd propose splitting the two, and treating this one as what its title currently says: "Don't use yes/no for caret browsing dialog".

Marking as NEW.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

7 years ago
Whiteboard: [CLOSEME INVA/WONT?]
Adding Bug 454520 to the See Also, as it proposes having the "No" button focused by default in the F7 dialog.
See Also: → bug 454520
You need to log in before you can comment on or make changes to this bug.