358987 - Show attachments with colored syntax highlighting in certain views

Status: NEW

(Bugzilla :: Attachments & Requests, enhancement, P2)

Description

[Jason Spiro]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6

It would be great if attachment.cgi's diff view showed attachments in syntax-highlighted color, just like Vim and Emacs do.

Reproducible: Always

Comment 1

[Jason Spiro]

A quick CPAN search (http://search.cpan.org/search?query=highlight&mode=all) shows there are a variety of Perl modules that do syntax highlighting, including:

Syntax::Highlight::Engine::Kate (rated four and a half stars)
    http://search.cpan.org/~hanje/Syntax-Highlight-Engine-Kate-0.02/
Syntax::Highlight::Universal
    http://search.cpan.org/~palant/Syntax-Highlight-Universal-0.4/
Text::Highlight
    http://search.cpan.org/~icrf/text-highlight-0.04/

Perhaps it would be possible to modify Bugzilla to check for the presence of one of these modules and to use them if so?

Comment 2

[Frédéric Buclin]

Not sure this will be very useful as what you attach is most of the time a patch rather than a full file. And so the highlightning would be incorrect. I prefer not to highlight anything than highlightning the file incorrectly.

Comment 3

[Frédéric Buclin]

The only situation where this feature could be useful and the patch correctly highlighted is when being in "context=file" mode. Maybe should this be the only case where this feature is used.

Comment 5

[Max Kanat-Alexander]

We could also use http://softwaremaniacs.org/soft/highlight/en/ (as mentioned in the above dupe).