Closed Bug 359000 Opened 13 years ago Closed 13 years ago

R_386_PC32 relocations in libnecko.so (and others) when building on FC6 with --with-system-zlib

Categories

(Core :: Networking, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: stephen.moehle, Assigned: dbaron)

References

Details

(Keywords: fixed1.8.0.9, fixed1.8.1.1, Whiteboard: [patch])

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061028 Firefox/3.0a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061028 Firefox/3.0a1

This is a follow on of sorts to bug 358559. When building a trunk Firefox or Thunderbird on FC6 with --with-system-zlib, libnecko.so, libjar50.so, and libxpinstall.so have R_386_PC32 rellocations that prevent the app from loading under SELinux in enforcing mode.

The relocations are all from zlib and are are:
crc32
inflate
inflateInit2_
inflateInit_
inflateEnd
inflateReset

Adding zlib.h to config/system-headers fixes the problem.

Reproducible: Always
Attached patch Add zlib.h to system-headers. (obsolete) — Splinter Review
If having zlib.h in system-headers is safe when --with-system-zlib is not specified, then this patch fixes the problem
It is not correct. We will need to add zlib.h to the wrapped headers conditionally.
Status: UNCONFIRMED → NEW
Ever confirmed: true
This fixes both this bug and bug 359001.

I tested it with my normal build configuration (and it didn't generate either header) and then with --with-system-zlib --with-system-png (and it generated both).
Assignee: nobody → dbaron
Attachment #244281 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #244633 - Flags: review?(benjamin)
Whiteboard: [patch]
Attachment #244633 - Flags: review?(benjamin) → review+
Checked in to trunk.  Thanks for pointing this out.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 244633 [details] [diff] [review]
patch for bug 359000 and bug 359001

This is a low risk patch that will, along with the other dependencies of bug
359275:

* allow Linux distros to take advantage of improved load and runtime
performance with WRAP_SYSTEM_HEADERS, other performance optimizations
(prelinking), and security improvements (SELinux)

* make it easier for developers to build on new distributions like Fedora Core
6
Attachment #244633 - Flags: approval1.8.1.1?
Attachment #244633 - Flags: approval1.8.0.9?
Comment on attachment 244633 [details] [diff] [review]
patch for bug 359000 and bug 359001

approved for 1.8/1.8.0 branches, a=dveditz
Attachment #244633 - Flags: approval1.8.1.1?
Attachment #244633 - Flags: approval1.8.1.1+
Attachment #244633 - Flags: approval1.8.0.9?
Attachment #244633 - Flags: approval1.8.0.9+
Fix checked in to MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.
You need to log in before you can comment on or make changes to this bug.