359000 - R_386_PC32 relocations in libnecko.so (and others) when building on FC6 with --with-system-zlib

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Stephen Moehle]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061028 Firefox/3.0a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061028 Firefox/3.0a1

This is a follow on of sorts to bug 358559. When building a trunk Firefox or Thunderbird on FC6 with --with-system-zlib, libnecko.so, libjar50.so, and libxpinstall.so have R_386_PC32 rellocations that prevent the app from loading under SELinux in enforcing mode.

The relocations are all from zlib and are are:
crc32
inflate
inflateInit2_
inflateInit_
inflateEnd
inflateReset

Adding zlib.h to config/system-headers fixes the problem.

Reproducible: Always

Comment 1

[Stephen Moehle]

Attachment: Add zlib.h to system-headers.

If having zlib.h in system-headers is safe when --with-system-zlib is not specified, then this patch fixes the problem

Comment 2

[Benjamin Smedberg]

It is not correct. We will need to add zlib.h to the wrapped headers conditionally.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch for bug 359000 and bug 359001

This fixes both this bug and bug 359001.

I tested it with my normal build configuration (and it didn't generate either header) and then with --with-system-zlib --with-system-png (and it generated both).

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.  Thanks for pointing this out.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 244633 [details] [diff] [review]
patch for bug 359000 and bug 359001

This is a low risk patch that will, along with the other dependencies of bug
359275:

* allow Linux distros to take advantage of improved load and runtime
performance with WRAP_SYSTEM_HEADERS, other performance optimizations
(prelinking), and security improvements (SELinux)

* make it easier for developers to build on new distributions like Fedora Core
6

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 244633 [details] [diff] [review]
patch for bug 359000 and bug 359001

approved for 1.8/1.8.0 branches, a=dveditz

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.