359016 - JS error 'this.currentItem has no properties' in calItemBase propertyEnumerator

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Thomas Benisch]

The propertyEnumerator in calItemBase returns JavaScript errors
when used in calWcapCalendar.tunnelXProps():

'[JavaScript Error: "currentItem is not defined" {file: "file:///D:/Development2/pim/wntmsci10/misc/mozilla/dist/xpi-stage/lightning/js/calItemBase.js" line:339}]' when calling method: [nsISimpleEnumerator::getNext]

'[JavaScript Error: "this.currentItem has no properties" {file: "file:///D:/Development2/pim/wntmsci10/misc/mozilla/dist/xpi-stage/lightning/js/calItemBase.js" line:319}]' when calling method: [nsISimpleEnumerator::hasMoreElements]

Comment 1

[Thomas Benisch]

Attachment: patch for 'currentItem is not defined'

This patch fixes the JavaScript error 'currentItem is not defined'.

Comment 2

[Thomas Benisch]

The fix for 'currentItem is not defined' is rather trivial, see
comment #1.

The JavaScript error 'this.currentItem has no properties' is
returned, if this.firstEnumerator and this.currentItem are
null or undefined. As the whole code in hasMoreElements()
seems to be a little bit hacky (e.g. why is
((this.currentItem = null) == null) needed?) this error
should be fixed by someone with some more insight.

Comment 3

[Joey Minta]

Comment on attachment 244296 [details] [diff] [review]
patch for 'currentItem is not defined'

r1/2=jminta, nice catch :)

Comment 4

[Thomas Benisch]

patch for 'currentItem is not defined' checked in on MOZILLA_1_8_BRANCH and trunk

Comment 5

[Simon Paquet [:sipaq]]

The patch for this was checked in back in November 2006.

Comment 6

[Thomas Benisch]

(In reply to comment #5)
> The patch for this was checked in back in November 2006.

That's only half of the truth. The patch fixes the first problem 'currentItem is
not defined' (see description). The second problem 'this.currentItem has no
properties' is still open (see comment #2). Therefore I propose to reopen this
issue.

Comment 7

[Simon Paquet [:sipaq]]

You're right, Thomas. Thanks for the information.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

I think we can close this bug, the code has changed a lot and I think all relevant bits have been superseded.