Last Comment Bug 359331 - modutil -changepw strict shutdown failure
: modutil -changepw strict shutdown failure
Product: NSS
Classification: Components
Component: Tools (show other bugs)
: 3.11.3
: All All
: P2 normal (vote)
: 3.12
Assigned To: Alexei Volkov
Depends on:
  Show dependency treegraph
Reported: 2006-11-02 17:06 PST by Nelson Bolyard (seldom reads bugmail)
Modified: 2007-01-04 16:34 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

destroy slot before calling NSS_Shutdown (1.49 KB, patch)
2006-11-10 11:58 PST, Alexei Volkov
nelson: review+
Details | Diff | Splinter Review

Description Nelson Bolyard (seldom reads bugmail) 2006-11-02 17:06:38 PST
Let $FIPS be the name of a directory containing an NSS DB file trio 
configured to run in FIPS mode.

When environment variable NSS_STRICT_SHUTDOWN is set to 1,  the command 
   modutil.exe -dbdir $FIPS -changepw "NSS FIPS 140-2 Certificate DB"
crashes in NSS_Shutdown due to a reference leak.

This bug was formerly recorded as a comment in bug 354423.
Comment 1 Nelson Bolyard (seldom reads bugmail) 2006-11-02 17:07:38 PST
I filed this as a "tools" bug, assuming that the bug is in the modutil program.
If the bug is found to be in the NSS libraries, please change this to a 
libraries bug.
Comment 2 Alexei Volkov 2006-11-10 11:58:40 PST
Created attachment 245249 [details] [diff] [review]
destroy slot before calling NSS_Shutdown
Comment 3 Nelson Bolyard (seldom reads bugmail) 2006-11-11 12:05:49 PST
Comment on attachment 245249 [details] [diff] [review]
destroy slot before calling NSS_Shutdown

Please combine this patch with the patch for bug 354423, which also patches this same function in cmd/modutil/pk11.c, and do one checkin that fixes both bugs.  Thanks.
Comment 4 Alexei Volkov 2007-01-04 16:34:18 PST
/cvsroot/mozilla/security/nss/cmd/modutil/pk11.c,v  <--  pk11.c
new revision: 1.25; previous revision: 1.24
/cvsroot/mozilla/security/nss/cmd/tests/remtest.c,v  <--  remtest.c
new revision: 1.4; previous revision: 1.3

Note You need to log in before you can comment on or make changes to this bug.