359566 - urlbar favicon sometimes not correctly displayed during drag&drop to tab event

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[Arie Paap [:wildmyron]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061103 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061103 Minefield/3.0a1

The favicon will occasionally not update correctly. I have only found this to be a problem when changing from a tab which does not have a favicon (i.e. default favicon). Subsequently hovering over a tab with it's own favicon will result in the default favicon remaining.

Reproducible: Always

Steps to Reproduce:
1. Open a few tabs with different favicons. Include one without a favicon (e.g. http://www.squarefree.com/burningedge/ )
2. Select some text on one of these pages.
3. Drag this text to the tab bar and hover over "The Burning Edge" tab and then over other tabs.

Actual Results:  
After hovering over the "The Burning Edge" tab, favicons for other tabs are not displayed when switching to them.

Expected Results:  
Favicons correctly displayed

If there are two tabs with the same favicon, hovering over these in succession will cause the favicon to be correctly displayed again, until switching to a tab with the default favicon again. In all other cases the favicon appears to be correctly displayed.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Is this a dupe of bug 359515?

Comment 2

[Arie Paap [:wildmyron]]

(In reply to comment #1)
> Is this a dupe of bug 359515?

Quite possibly. They seemed different enough to warrant separate bugs (that bug only affects icons which haven't been loaded yet whereas this one happens every time), but this bug may also be a reflection of the "timers don't work on windows bug". I don't understand how onLocationChange works to know if that is the cause. If it is, then I guess it depends on whether it's worth fixing or wait until bug 203573 is fixed.

Comment 3

[Martijn Wargers (dead)]

I can't fix this bug nor bug 359515 (I think they're basically the same).
I think they would be fixed if bug 203573 would be fixed.
I don't think these bugs are that bad that the fix for bug 248612 should be backed out.

Comment 4

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4pre) Gecko/2008022604 Minefield/3.0b4pre] (nightly) (W2Ksp4)

R.WorksForMe.
Bug 389931, fixed (in Gecko/2008022704) bug 359515, which prevented the default icon on the Burningedge tab itself to show up during the drag;
but, other than that, I can't reproduce the current bug, per steps, on the other tabs.

I guess this was fixed by another patch in the meantime.
Reopen if I missed something.