359826 - Relocate "Block Web Advertising" checkbox to prevent confusion with pop-up exceptions list

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

------- Comment #8 From froodian  2006-11-07 08:39 PST -------

Although the problem as reported is INVALID, perhaps this is an indication that
we should move the "block web advertising" checkbox to below the pop-up
exceptions list, or move the pop-up prefs to the bottom of the annoyance
blocking section to avoid further confusion.

Comment 1

[froodian (Ian Leue)]

Attachment: New Webfeatures.nib

This leaves the prefs in place.  Per IRC, we want to stress "block web advertising", since it's something that only Camino has out of the box.  Instead, this changes the button text and hint text to make it more clear what's being excepted.

Comment 2

[froodian (Ian Leue)]

Attachment: Screenshot

Comment 3

[froodian (Ian Leue)]

Attachment: New Webfeatures.nib

This also fixes resizing and the tab loop (and shift-tab especially) in the exceptions panel.  Visually there are no changes–just behaviorally.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 244961 [details]
New Webfeatures.nib

Thanks for fixing all those after-finds ;)  r=ardissone

Comment 5

[Stuart Morgan]

Comment on attachment 244961 [details]
New Webfeatures.nib

sr=smorgan

Comment 6

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.