Relocate "Block Web Advertising" checkbox to prevent confusion with pop-up exceptions list

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Preferences
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: froodian (Ian Leue))

Tracking

({fixed1.8.1.1})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.1.1

Details

Attachments

(2 attachments, 1 obsolete attachment)

68.97 KB, image/png
Details
12.83 KB, application/zip
Smokey Ardisson (offline for a while; not following bugs - do not email)
: review+
Stuart Morgan
: superreview+
Details
------- Comment #8 From froodian  2006-11-07 08:39 PST -------

Although the problem as reported is INVALID, perhaps this is an indication that
we should move the "block web advertising" checkbox to below the pop-up
exceptions list, or move the pop-up prefs to the bottom of the annoyance
blocking section to avoid further confusion.
Target Milestone: --- → Camino1.1
(Assignee)

Comment 1

11 years ago
Created attachment 244949 [details]
New Webfeatures.nib

This leaves the prefs in place.  Per IRC, we want to stress "block web advertising", since it's something that only Camino has out of the box.  Instead, this changes the button text and hint text to make it more clear what's being excepted.
Assignee: nobody → stridey
Status: NEW → ASSIGNED
Attachment #244949 - Flags: review?(alqahira)
(Assignee)

Comment 2

11 years ago
Created attachment 244950 [details]
Screenshot
(Assignee)

Comment 3

11 years ago
Created attachment 244961 [details]
New Webfeatures.nib

This also fixes resizing and the tab loop (and shift-tab especially) in the exceptions panel.  Visually there are no changes–just behaviorally.
Attachment #244949 - Attachment is obsolete: true
Attachment #244961 - Flags: review?(alqahira)
Attachment #244949 - Flags: review?(alqahira)
Comment on attachment 244961 [details]
New Webfeatures.nib

Thanks for fixing all those after-finds ;)  r=ardissone
Attachment #244961 - Flags: superreview?(stuart.morgan)
Attachment #244961 - Flags: review?(alqahira)
Attachment #244961 - Flags: review+

Comment 5

11 years ago
Comment on attachment 244961 [details]
New Webfeatures.nib

sr=smorgan
Attachment #244961 - Flags: superreview?(stuart.morgan) → superreview+
(Assignee)

Comment 6

11 years ago
Checked in on 1.8branch and trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.