359888 - Compose page does not come up in Yahoo mail (not beta)

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Brian Polidoro]

Going to the compose page in yahoo mail by either clicking compose or replying to an email results in the throbber spinning forever and nothing else happening.  

2006110304 works
2006110404 broke
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-11-03+%3A04%3A00%3A00&maxdate=2006-11-04+04%3A00%3A00&cvsroot=%2Fcvsroot

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Most likely a regression from bug 343730, I'd say (bug 358106 would be my next guess). Sicking's on the hook for both :)

Comment 2

[Bill Gianopoulos [:WG9s]]

(In reply to comment #1)
> Most likely a regression from bug 343730, I'd say (bug 358106 would be my next
> guess). Sicking's on the hook for both :)
> 
I verified this is caused by the checkin for 343730.

The good news is I also verified this issue does not exist on the current branch, which has some of the 343730 code included.

Comment 3

[Bill Gianopoulos [:WG9s]]

Attachment: testcase (zip of yahoo compose page saved as web page complete)

I did a save as webpage complete of the yahoo mail compose page so this can be worked on - looked at without needing a yahoo account.  I will try to find time to get this to a reduced testcase.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

The problem here was the NS_CONTENT_SCRIPT_IS_EVENTHANDLER success value bubbled up into the parser which was unable to deal with it, i.e. it used |== NS_OK| rather than |NS_SUCCEEDED|. Additionally I noticed that bug 343730 "broke" the eventhandler stuff since mIsEvaluated was always true when we got to the code that handled it.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 246996 [details] [diff] [review]
Patch to fix

     // If the script has NOT been executed yet then create a script
     // event handler if necessary...

The below code is unconditionally run, so remove the "if necessary" part of that comment.

r+sr=jst with that fixed.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Would be great if someone can verify that this fixes the real yahoo site

Comment 8

[Brian Polidoro]

VERIFIED with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061129 Minefield/3.0a1 ID:2006112916 [cairo]

Comment 9

[lthemole]

(In reply to comment #1)
> Most likely a regression from bug 343730, I'd say (bug 358106 would be my next
> guess). Sicking's on the hook for both :)
>