Closed Bug 359961 Opened 13 years ago Closed 13 years ago

prototype event dialog : attendee list has some usability issues

Categories

(Calendar :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: michael.buettner, Assigned: michael.buettner)

Details

Attachments

(1 file)

the attendee list of the 'invite attendees'-dialog has some usability issues.
- cursor traveling does not work as expected, i.e. while entering a name it's not possible to move the cursor left or right.
- after a name has been entered the cursor should be placed on the next line automatically.
- pressing tab should always move to the next line.
- once the autoselect-box came up cursor traveling is screwed up, i.e. cursor up or down brings an empty popup instead of moving to the previous or next line.
Attached patch patch v1Splinter Review
patch resolves above mentioned issues.
Attachment #245001 - Flags: first-review?(thomas.benisch)
I only have some minor issues.

+            var set_focus = function func() {

In this case the function name func is unnecessary.

+              if (aRow <= firstVisibleRow)
+                listbox.scrollToIndex(aRow-1);
+              else
+                if (aRow-1 >= (firstVisibleRow+numOfVisibleRows))
+                  listbox.scrollToIndex(aRow-numOfVisibleRows);

I prefer to use curly brackets.
 
-            var input = document.getAnonymousElementByAttribute(node, "anonid", "input");
-            input.focus();
+              var input = document.getAnonymousElementByAttribute(node, "anonid", "input");
+              input.focus();
+            }
+            setTimeout(set_focus,0);

Why do you need a timer at all?

+            case KeyEvent.DOM_VK_TAB:

What about supporting SHIFT TAB to move to the previous line?

r1=tbe
Comment on attachment 245001 [details] [diff] [review]
patch v1

r1=tbe
Attachment #245001 - Flags: first-review?(thomas.benisch) → first-review+
(In reply to comment #2)
> Why do you need a timer at all?
Since I need to defer this event in order to get this one executed after the focus-event which gets injected into the queue after my setFocus() method has been called.

> What about supporting SHIFT TAB to move to the previous line?
Good idea, I added this to the patch.

Checked in on trunk and MOZILLA_1_8_BRANCH -> FIXED
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.