360111 - dying js context

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Michael Büttner (no reviews TFN)]

assume a dialog calls some asynchronous method on a provider with an interface that should be called back in order to receive the result. in case the js context of the dialog vanishes before the provider actually calls back through the interface an exception will be thrown (JavaScript Error: "Components is not defined").

The scenario described above happens immediately in case you access the 'invite attendees'-dialog of the prototypes event dialog and cancel the dialog before all free/busy requests have been answered by the WCAP provider.

Comment 1

[Michael Büttner (no reviews TFN)]

daniel: wouldn't it be a good idea to have some interface (e.g. calICancelable) that gets returned upon calling something like getFreeBusyTimes()? I think this would be a clean solution to the problem. otherwise I need to wrap the call outside of the dialog, which seems to be more of a hack than anything else.

Comment 2

[Daniel Boelzle [:dbo]]

(In reply to comment #1)
> daniel: wouldn't it be a good idea to have some interface (e.g. calICancelable)
> that gets returned upon calling something like getFreeBusyTimes()? I think this
> would be a clean solution to the problem. otherwise I need to wrap the call
> outside of the dialog, which seems to be more of a hack than anything else.

Yes, I have had similar thoughts last week for all async calls currently in play. I will post a proposal to the ng.

Comment 3

[Michael Büttner (no reviews TFN)]

Attachment: patch v1

Since the WCAP provider now supports cancelable requests, this patch contains the necessary modifications in order to make use of the latest WCAP api.

Comment 4

[Michael Büttner (no reviews TFN)]

Checked in on trunk and MOZILLA_1_8_BRANCH