Closed
Bug 360241
Opened 19 years ago
Closed 19 years ago
Add a bunch of accesskeys to Publishing dialogs/tabs
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: prometeo.bugs, Assigned: prometeo.bugs)
Details
Attachments
(1 file, 1 obsolete file)
|
16.31 KB,
patch
|
prometeo.bugs
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061110 SeaMonkey/1.5a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061110 SeaMonkey/1.5a
Publishing settings dialog and Publish dialog's tabs are missing a buch of accesskeys, plus there are a few unused entities to get rid of in the process.
Reproducible: Always
|
Assignee | |
Comment 1•19 years ago
|
||
|
|
Assignee | |
Updated•19 years ago
|
Attachment #245202 -
Flags: review?(daniel)
Comment on attachment 245202 [details] [diff] [review]
Starting point...
r=me
Attachment #245202 -
Flags: review?(daniel) → review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #245202 -
Flags: superreview?(neil)
|
||
Comment 3•19 years ago
|
||
Comment on attachment 245202 [details] [diff] [review]
Starting point...
> <textbox id="SiteNameInput" class="MinWidth20em"
>- tooltiptext="&siteName.tooltip;" oninput="onInputSettings();" flex="1"/>
>+ tooltiptext="&siteName.tooltip;" oninput="onInputSettings();"
>+ flex="1"/>
> <textbox id="UsernameInput" class="MinWidth10em"
>- tooltiptext="&username.tooltip;" oninput="onInputSettings();" flex="1"/>
>+ tooltiptext="&username.tooltip;" oninput="onInputSettings();"
>+ flex="1"/>
Those flexes look lonely ;-) Put them on the first line perhaps?
>+ <label value="&pageTitle.label;" accesskey="&pageTitle.accesskey;" control="PageTitleInput"/>
>+ <label value="&filename.label;" accesskey="&filename.accesskey;" control="FilenameInput"/>
You didn't wrap these for some reason?
Attachment #245202 -
Flags: superreview?(neil) → superreview+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Patch for checkin. I can't move over sr+.
Attachment #245202 -
Attachment is obsolete: true
Attachment #249080 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [checkin needed]
|
||
Updated•19 years ago
|
Assignee: composer → prometeo.bugs
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 5•19 years ago
|
||
mozilla/editor/ui/dialogs/content/EditorPublish.xul 1.23
mozilla/editor/ui/dialogs/content/EditorPublishOverlay.xul 1.13
mozilla/editor/ui/dialogs/content/EditorPublishSettings.xul 1.11
mozilla/editor/ui/locales/en-US/chrome/dialogs/EditorPublish.dtd 1.2
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
|
||
Updated•19 years ago
|
Summary: Add a buch of accesskeys to Publishing dialogs/tabs → Add a bunch of accesskeys to Publishing dialogs/tabs
You need to log in
before you can comment on or make changes to this bug.
Description
•