360258 - Minor improvements of Firefox 2.0 Catalan translation

Status: RESOLVED FIXED

(Mozilla Localizations :: ca / Catalan, defect)

Description

[Toni Hermoso Pulido]

Comment 1

[Toni Hermoso Pulido]

Attachment: Corrections patch for Catalan Firefox 2

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 245206 [details] [diff] [review]
Corrections patch for Catalan Firefox 2

>Index: browser/chrome/browser/browser.properties
>===================================================================
>RCS file: /l10n/l10n/ca/browser/chrome/browser/browser.properties,v
>retrieving revision 1.11.2.17
>diff -r1.11.2.17 browser.properties
>26c26
>< contextMenuSearchText=Cerca «%S» a %S
>---
>> contextMenuSearchText=Cerca a %S «%S»

Do you want to do this or rather

contextMenuSearchText=Cerca «%2$S» a %1$S

Should be tested, but that should work.

Comment 3

[Toni Hermoso Pulido]

Attachment: alternative patch

Comment 4

[Toni Hermoso Pulido]

Attachment: alternative patch

Comment 5

[Toni Hermoso Pulido]

Let's try it :)


(In reply to comment #2)
> (From update of attachment 245206 [details] [diff] [review] [edit])
> >Index: browser/chrome/browser/browser.properties
> >===================================================================
> >RCS file: /l10n/l10n/ca/browser/chrome/browser/browser.properties,v
> >retrieving revision 1.11.2.17
> >diff -r1.11.2.17 browser.properties
> >26c26
> >< contextMenuSearchText=Cerca «%S» a %S
> >---
> >> contextMenuSearchText=Cerca a %S «%S»
> 
> Do you want to do this or rather
> 
> contextMenuSearchText=Cerca «%2$S» a %1$S
> 
> Should be tested, but that should work.
> 

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 245213 [details] [diff] [review]
alternative patch

Could you please test this locally first?

I'd be surprised if this one worked, as the first string doesn't have the %2$S.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 245214 [details] [diff] [review]
alternative patch

This patch is a dupe, AFAICT.

Comment 8

[Toni Hermoso Pulido]

Attachment: Final patch, verified

Search parameters verified.

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 245227 [details] [diff] [review]
Final patch, verified

[ca] approval granted to land minor corrections for Firefox 2.0.0.1.

Please use the fixed1.8.1.1 and verified1.8.1.1 keywords to track landing and testing.

Comment 10

[Toni Hermoso Pulido]

Attachment: History accesskey change

Users asked for it.

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 245324 [details] [diff] [review]
History accesskey change

[ca] accesskey fix approved for Firefox 2.0.0.1.

Comment 12

[Axel Hecht [:Pike]]

[mass-verified1.8.1.1 message, filter on this if you need to]

This bug has an approved patch, but not the verified1.8.1.1 keyword.

Please make sure that the approved patch is landed (add the fixed1.8.1.1 keyword then) and tested. If you verified that the bug in question is indeed fixed on the 1.8 branch nightlies, please add the verified1.8.1.1 keyword.

We need to get the QA activities around Firefox 2.0.0.1 up to speed so that we can feel good about releasing this update.