tabbrowser assumes req.image exists

RESOLVED FIXED in seamonkey1.1final

Status

SeaMonkey
UI Design
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com], Assigned: Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com])

Tracking

({fixed-seamonkey1.0.7, fixed-seamonkey1.1})

1.8 Branch
seamonkey1.1final
x86
Windows XP
fixed-seamonkey1.0.7, fixed-seamonkey1.1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/tabbrowser.xml#378
Apparently req can exist, with req.image = null.  The bug exists in SM1.0.x and trunk, so it probably exists in SM1.1 too.

The URL is the image that caused this, but it's due to server bustage, which will probably be fixed.
Created attachment 245303 [details] [diff] [review]
for trunk
Assignee: guifeatures → cst
Status: NEW → ASSIGNED
Attachment #245303 - Flags: review?(neil)
Version: Other Branch → 1.8 Branch

Comment 2

11 years ago
Comment on attachment 245303 [details] [diff] [review]
for trunk

You don't need to check anything here, because you're already testing the status (although you could check the image instead of the status if you prefer).
Attachment #245303 - Flags: review?(neil) → review-
Created attachment 245717 [details] [diff] [review]
patch for 1.8

For SeaMonkey 1.1 final
Attachment #245303 - Attachment is obsolete: true
Attachment #245717 - Flags: review?(neil)
Created attachment 245718 [details] [diff] [review]
patch for 1.8.0

Do we want to fix this on 1.8.0 branch?
Attachment #245718 - Flags: review?(neil)

Updated

11 years ago
Attachment #245718 - Flags: review?(neil) → review+

Comment 5

11 years ago
Comment on attachment 245717 [details] [diff] [review]
patch for 1.8

These two patches are the same, no? Also, isn't there some width code on the trunk in the fallback case?
Attachment #245717 - Flags: review?(neil) → review+
Attachment #245717 - Flags: approval-seamonkey1.1?
Comment on attachment 245718 [details] [diff] [review]
patch for 1.8.0

a? for 1.0.7, but we have no flag for that.
Attachment #245718 - Flags: approval-seamonkey1.0.6?
Neil, yes, they're the same.  I thought trunk protects req.image.* with a check of req.imageStatus.

Comment 8

11 years ago
Comment on attachment 245718 [details] [diff] [review]
patch for 1.8.0

a=me for SeaMonkey 1.0.7
Attachment #245718 - Flags: approval-seamonkey1.0.6? → approval-seamonkey1.0.7+

Comment 9

11 years ago
Comment on attachment 245717 [details] [diff] [review]
patch for 1.8

a=me for SeaMonkey 1.1
Attachment #245717 - Flags: approval-seamonkey1.1? → approval-seamonkey1.1+
I will land on 1.8.1 first, after Neil is satisfied with my answers.

Comment 11

11 years ago
(In reply to comment #7)
>I thought trunk protects req.image.* with a check of req.imageStatus.
Yes, it does... there are a lot of {}s which confused me initially.
Fixed on 1.8.1, will let it bake before fixing 1.8.0
Keywords: fixed-seamonkey1.1
timeless checked this in for me on 1.8.0 branch since I'm out of town.
Keywords: fixed-seamonkey1.0.7
I guess this is fixed since it doesn't affect trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

9 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.