Closed Bug 360329 Opened 19 years ago Closed 19 years ago

tabbrowser assumes req.image exists

Categories

(SeaMonkey :: UI Design, defect)

Product:
SeaMonkey
Component:
UI Design
Version:
1.8 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey1.1final

People

(Reporter: csthomas, Assigned: csthomas)

References

(
URL
)

Details

(Keywords: fixed-seamonkey1.0.7, fixed-seamonkey1.1)

Attachments

(2 files, 1 obsolete file)

patch for 1.8
1.68 KB, patch
neil
: review+
kairo
: approval-seamonkey1.1+
Details | Diff | Splinter Review
patch for 1.8.0
1.65 KB, patch
neil
: review+
kairo
: approval-seamonkey1.0.7+
Details | Diff | Splinter Review
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/tabbrowser.xml#378 Apparently req can exist, with req.image = null. The bug exists in SM1.0.x and trunk, so it probably exists in SM1.1 too. The URL is the image that caused this, but it's due to server bustage, which will probably be fixed.
Attached patch for trunk (obsolete) — — Splinter Review
Assignee: guifeatures → cst
Status: NEW → ASSIGNED
Attachment #245303 - Flags: review?(neil)
Version: Other Branch → 1.8 Branch
Comment on attachment 245303 [details] [diff] [review] for trunk You don't need to check anything here, because you're already testing the status (although you could check the image instead of the status if you prefer).
Attachment #245303 - Flags: review?(neil) → review-
Attached patch patch for 1.8 — — Splinter Review
For SeaMonkey 1.1 final
Attachment #245303 - Attachment is obsolete: true
Attachment #245717 - Flags: review?(neil)
Attached patch patch for 1.8.0 — — Splinter Review
Do we want to fix this on 1.8.0 branch?
Attachment #245718 - Flags: review?(neil)
Attachment #245718 - Flags: review?(neil) → review+
Comment on attachment 245717 [details] [diff] [review] patch for 1.8 These two patches are the same, no? Also, isn't there some width code on the trunk in the fallback case?
Attachment #245717 - Flags: review?(neil) → review+
Attachment #245717 - Flags: approval-seamonkey1.1?
Comment on attachment 245718 [details] [diff] [review] patch for 1.8.0 a? for 1.0.7, but we have no flag for that.
Attachment #245718 - Flags: approval-seamonkey1.0.6?
Neil, yes, they're the same. I thought trunk protects req.image.* with a check of req.imageStatus.
Comment on attachment 245718 [details] [diff] [review] patch for 1.8.0 a=me for SeaMonkey 1.0.7
Attachment #245718 - Flags: approval-seamonkey1.0.6? → approval-seamonkey1.0.7+
Comment on attachment 245717 [details] [diff] [review] patch for 1.8 a=me for SeaMonkey 1.1
Attachment #245717 - Flags: approval-seamonkey1.1? → approval-seamonkey1.1+
I will land on 1.8.1 first, after Neil is satisfied with my answers.
(In reply to comment #7) >I thought trunk protects req.image.* with a check of req.imageStatus. Yes, it does... there are a lot of {}s which confused me initially.
Fixed on 1.8.1, will let it bake before fixing 1.8.0
Keywords: fixed-seamonkey1.1
timeless checked this in for me on 1.8.0 branch since I'm out of town.
Keywords: fixed-seamonkey1.0.7
I guess this is fixed since it doesn't affect trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: