Closed
Bug 360528
Opened 18 years ago
Closed 18 years ago
Can no longer import trusted email cert
Categories
(Core :: Security: PSM, defect, P1)
Tracking
()
VERIFIED
FIXED
People
(Reporter: KaiE, Assigned: KaiE)
References
Details
(Keywords: regression, verified1.8.1.2)
Attachments
(1 file)
953 bytes,
patch
|
rrelyea
:
review+
wtc
:
review+
jay
:
approval1.8.1.2+
|
Details | Diff | Splinter Review |
We introduced a regression with bug 310446. The regression causes us to fail importing email certs.
Assignee | ||
Updated•18 years ago
|
Keywords: regression
Priority: -- → P1
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #245431 -
Flags: review?(rrelyea)
Comment 2•18 years ago
|
||
Kai, you also need to do something about CERTCertificateListCleaner chainCleaner(certChain); which is now initialized with certChain=nsnull. There are two instances of chainCleaner.
Comment 3•18 years ago
|
||
I see that CERTCertificateListCleaner takes a reference of its argument, so the code is correct. Please ignore my previous comment.
Comment 4•18 years ago
|
||
Comment on attachment 245431 [details] [diff] [review] Patch v1 r+ = relyea.
Attachment #245431 -
Flags: review?(rrelyea) → review+
Assignee | ||
Comment 5•18 years ago
|
||
fixed on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•18 years ago
|
||
Comment on attachment 245431 [details] [diff] [review] Patch v1 We should get this regression fix into Thunderbird 2. Not sure whether to ask for approval1.8.1.1 or approval1.8.1.2
Attachment #245431 -
Flags: approval1.8.1.2?
Attachment #245431 -
Flags: approval1.8.1.1?
Comment 7•18 years ago
|
||
Kai: We are done with 1.8.1.1, so nominating for 1.8.1.2. Also cc'ing mscott so this bug doesn't get lost for Thunderbird 2 (since there is no flag for it here).
Flags: wanted1.8.1.x+
Flags: blocking1.8.1.2?
Assignee | ||
Updated•18 years ago
|
Attachment #245431 -
Flags: approval1.8.1.1?
Updated•18 years ago
|
Flags: blocking1.8.1.2? → blocking1.8.1.2+
Comment 8•18 years ago
|
||
Comment on attachment 245431 [details] [diff] [review] Patch v1 Approved for 1.8 branch, a=jay for drivers.
Attachment #245431 -
Flags: approval1.8.1.2? → approval1.8.1.2+
Comment 9•18 years ago
|
||
Comment on attachment 245431 [details] [diff] [review] Patch v1 r=wtc.
Attachment #245431 -
Flags: review+
Comment 11•18 years ago
|
||
Verified fixed for 1.8.1.2 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/20070104 Thunderbird/2.0b1 Mnenhy/0.7.4.10002 and my personal thawte email cert.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.2 → verified1.8.1.2
Comment 13•17 years ago
|
||
What presently-released versions of FF 2 (if any) contain this fix?
Assignee | ||
Comment 14•17 years ago
|
||
Nelson, 1.8.1.2 is equivalent to Firefox 2.0.0.2, which was the first version that contains the fix.
You need to log in
before you can comment on or make changes to this bug.
Description
•