Closed Bug 360528 Opened 16 years ago Closed 16 years ago
Can no longer import trusted email cert
We introduced a regression with bug 310446. The regression causes us to fail importing email certs.
Kai, you also need to do something about CERTCertificateListCleaner chainCleaner(certChain); which is now initialized with certChain=nsnull. There are two instances of chainCleaner.
I see that CERTCertificateListCleaner takes a reference of its argument, so the code is correct. Please ignore my previous comment.
Comment on attachment 245431 [details] [diff] [review] Patch v1 r+ = relyea.
Attachment #245431 - Flags: review?(rrelyea) → review+
fixed on trunk.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment on attachment 245431 [details] [diff] [review] Patch v1 We should get this regression fix into Thunderbird 2. Not sure whether to ask for approval184.108.40.206 or approval220.127.116.11
Kai: We are done with 18.104.22.168, so nominating for 22.214.171.124. Also cc'ing mscott so this bug doesn't get lost for Thunderbird 2 (since there is no flag for it here).
Comment on attachment 245431 [details] [diff] [review] Patch v1 Approved for 1.8 branch, a=jay for drivers.
Attachment #245431 - Flags: approval126.96.36.199? → approval188.8.131.52+
Comment on attachment 245431 [details] [diff] [review] Patch v1 r=wtc.
Attachment #245431 - Flags: review+
I checked in the patch on the MOZILLA_1_8_BRANCH.
Verified fixed for 184.108.40.206 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:220.127.116.11pre) Gecko/20070104 Thunderbird/2.0b1 Mnenhy/0.7.4.10002 and my personal thawte email cert.
What presently-released versions of FF 2 (if any) contain this fix?
Nelson, 18.104.22.168 is equivalent to Firefox 22.214.171.124, which was the first version that contains the fix.
You need to log in before you can comment on or make changes to this bug.