Mentioned in bug 311781 comment 4. Both the toolbar item and menu item should get renamed to "Show/Hide Bookmark Manager" which better explains the toggle situation.
Created attachment 245985 [details] [diff] [review] fix This is really a strings change; the patch just changes the key to the AllOneWord style that we use more and is better for catching missing strings before the localizers have problems. The strings changes are to change these (the menu): "Hide All Bookmarks" = "Hide All Bookmarks"; "Show All Bookmarks" = "Show All Bookmarks"; to: "HideBookmarkManager" = "Hide Bookmark Manager"; "ShowBookmarkManager" = "Show Bookmark Manager"; and these (the toolbar tool tips): "ShowBookmarkMgrToolTip" = "Show all bookmarks"; "HideBookmarkMgrToolTip" = "Hide all bookmarks"; to: "ShowBookmarkMgrToolTip" = "Show bookmark manager"; "HideBookmarkMgrToolTip" = "Hide bookmark manager"; I'm leaving the toolbar item's text as is because it's pretty good already (Manage/Hide Bookmarks) and having the full text in the tooltip seems better than making the toolbar item's text significantly longer.
Comment on attachment 245985 [details] [diff] [review] fix Looks good to me (including not changing the toolbar buttons, for the reasons you mention)
Comment on attachment 245985 [details] [diff] [review] fix rs=pink
Checked in on trunk and MOZILLA_1_8_BRANCH.