Rename Show/hide bookmarks button and manager

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Toolbars & Menus
--
trivial
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: froodian (Ian Leue), Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.1})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.1.1

Details

Attachments

(1 attachment)

fix
1.02 KB, patch
froodian (Ian Leue)
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
Mentioned in bug 311781 comment 4.  Both the toolbar item and menu item should get renamed to "Show/Hide Bookmark Manager" which better explains the toggle situation.
(Assignee)

Comment 1

11 years ago
Created attachment 245985 [details] [diff] [review]
fix

This is really a strings change; the patch just changes the key to the AllOneWord style that we use more and is better for catching missing strings before the localizers have problems.

The strings changes are to change these (the menu):
"Hide All Bookmarks" = "Hide All Bookmarks";
"Show All Bookmarks" = "Show All Bookmarks";
to:
"HideBookmarkManager" = "Hide Bookmark Manager";
"ShowBookmarkManager" = "Show Bookmark Manager";

and these (the toolbar tool tips):
"ShowBookmarkMgrToolTip" = "Show all bookmarks";
"HideBookmarkMgrToolTip" = "Hide all bookmarks";
to:
"ShowBookmarkMgrToolTip" = "Show bookmark manager";
"HideBookmarkMgrToolTip" = "Hide bookmark manager";

I'm leaving the toolbar item's text as is because it's pretty good already (Manage/Hide Bookmarks) and having the full text in the tooltip seems better than making the toolbar item's text significantly longer.
Assignee: stridey → stuart.morgan
Status: NEW → ASSIGNED
Attachment #245985 - Flags: superreview?(mikepinkerton)
(Reporter)

Comment 2

11 years ago
Comment on attachment 245985 [details] [diff] [review]
fix

Looks good to me (including not changing the toolbar buttons, for the reasons you mention)
Attachment #245985 - Flags: review+
Comment on attachment 245985 [details] [diff] [review]
fix

rs=pink
Attachment #245985 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 4

11 years ago
Checked in on trunk and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.