Closed Bug 360644 Opened 13 years ago Closed 13 years ago

Rename Show/hide bookmarks button and manager

Categories

(Camino Graveyard :: Toolbars & Menus, defect, trivial)

PowerPC
macOS
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.5

People

(Reporter: froodian, Assigned: stuart.morgan+bugzilla)

Details

(Keywords: fixed1.8.1.1)

Attachments

(1 file)

fix
1.02 KB, patch
froodian
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review
Mentioned in bug 311781 comment 4.  Both the toolbar item and menu item should get renamed to "Show/Hide Bookmark Manager" which better explains the toggle situation.
Attached patch fixSplinter Review
This is really a strings change; the patch just changes the key to the AllOneWord style that we use more and is better for catching missing strings before the localizers have problems.

The strings changes are to change these (the menu):
"Hide All Bookmarks" = "Hide All Bookmarks";
"Show All Bookmarks" = "Show All Bookmarks";
to:
"HideBookmarkManager" = "Hide Bookmark Manager";
"ShowBookmarkManager" = "Show Bookmark Manager";

and these (the toolbar tool tips):
"ShowBookmarkMgrToolTip" = "Show all bookmarks";
"HideBookmarkMgrToolTip" = "Hide all bookmarks";
to:
"ShowBookmarkMgrToolTip" = "Show bookmark manager";
"HideBookmarkMgrToolTip" = "Hide bookmark manager";

I'm leaving the toolbar item's text as is because it's pretty good already (Manage/Hide Bookmarks) and having the full text in the tooltip seems better than making the toolbar item's text significantly longer.
Assignee: stridey → stuart.morgan
Status: NEW → ASSIGNED
Attachment #245985 - Flags: superreview?(mikepinkerton)
Comment on attachment 245985 [details] [diff] [review]
fix

Looks good to me (including not changing the toolbar buttons, for the reasons you mention)
Attachment #245985 - Flags: review+
Comment on attachment 245985 [details] [diff] [review]
fix

rs=pink
Attachment #245985 - Flags: superreview?(mikepinkerton) → superreview+
Checked in on trunk and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.