360658 - Weekly layout: No preview for 'Selected events' selection [Error: aStart has no properties]

Status: VERIFIED FIXED

(Calendar :: Printing, defect)

Description

[Koen Hendrickx]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061113 Calendar/0.4a1

When you want to print a weekly grid for a selection, the preview becomes empty. 
In the error-console, i got the message: 
[quote]Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061113 Calendar/0.4a1[/quote]

to reproduce:
1) add an event
2) select that event
3) go to print (ctrl-P)
4) select weekly grid
5) select selection


I also found that when you go from 'events in the current view' to 'selection', you get the message:
[quote]Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIBoxObject.getProperty]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/bindings/textbox.xml ::  :: line 102"  data: no][/quote]
This message, i get in every grid (monthly, weekly, list)

Comment 1

[Stefan Sitter [:ssitter]]

(In reply to comment #0)
> Error: uncaught exception: [Exception... "Component returned failure 
> code: 0x80004005 (NS_ERROR_FAILURE)  [nsIBoxObject.getProperty]"

That's a different issue and already reported with Bug 359773.

Comment 2

[Sebastian Schwieger]

I think, Koen pasted the wrong text. The error look like this:

Error: aStart has no properties
Source File: file:///C:/Programme/Calendar/js/calWeekPrinter.js
Line: 125

Confirming the inability to preview and print selected events in weekly planner.

Comment 3

[Koen Hendrickx]

sorry, it is indeed the text 
Error: aStart has no properties

sorry; wrong paste.

Comment 4

[Stefan Sitter [:ssitter]]

Confirmed. This is the error shown in console:
printDialog::refreshHtml:[Exception... "'[JavaScript Error: "aStart has no properties" {file: "file:///D:/sunbird/js/calWeekPrinter.js" line: 125}]' when calling method: [calIPrintFormatter::formatToHtml]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://calendar/content/printDialog.js :: refreshHtml :: line 202"  data: yes]

Comment 5

[Joey Minta]

Attachment: make aStart optional

The idl defines aStart as optional.  In that case, we should use the first day of the first item.

Comment 6

[Matthew (lilmatt) Willis]

Comment on attachment 246545 [details] [diff] [review]
make aStart optional

>Index: calendar/import-export/calWeekPrinter.js

>+    var end = aEnd || lastItem.startDate || lastItem.entryDate ||
>+               lastItem.dueDate;

Style nit: Align lastItem.dueDate with aEnd above it.

r=lilmatt with that

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 246545 [details] [diff] [review]
make aStart optional

r2=mvl

Comment 8

[Joey Minta]

Patch checked in.

Comment 9

[Stefan Sitter [:ssitter]]

Steps from comment #0 with Sunbird/0.4a1 (2006120509) still fail, no print preview is shown. Console shows:

printDialog::refreshHtml: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [calIDateTime.compare]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: file:///D:/sunbird/js/calWeekPrinter.js :: weekPrint_format :: line 139"  data: no]

Comment 10

[Joey Minta]

(In reply to comment #9)
OK, caused by a merge of the two patches fixing printing.

Comment 11

[Joey Minta]

Attachment: fix merge goo

Patch makes sure we only use the variables we know exist.

Comment 12

[Matthew (lilmatt) Willis]

Comment on attachment 247575 [details] [diff] [review]
fix merge goo

r=lilmatt

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 247575 [details] [diff] [review]
fix merge goo

r2=mvl

Comment 14

[Joey Minta]

patch checked in.

Comment 15

[Martin Schröder [:mschroeder]]

With Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070406 Calendar/0.5pre there is no "Weekly Planer" preview and no message in the error console. -> REOPEN

Comment 16

[Stefan Sitter [:ssitter]]

(In reply to comment #15)

Works for me using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.4pre) Gecko/20070406 Calendar/0.5pre. 
Weekly Planner layout is working fine for all print options.

Comment 17

[Martin Schröder [:mschroeder]]

WFM with a clean profile and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070406 Calendar/0.5pre. Sorry for wrongly reopening this bug.

Comment 18

[Damian Szczepanik]

Litmus testcase 4440 created