360710 - checksetup.pl needs to blacklist some non-working external modules

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Frédéric Buclin]

Due to many regressions or backward incompatibilities in external modules used by Bugzilla, a list of working and non-working versions has been set on Wiki:  http://wiki.mozilla.org/Bugzilla:FAQ:Software_Matrix

checksetup.pl should also contain a blacklist for these non-working versions of the external modules.

Comment 1

[Max Kanat-Alexander]

Blocker, per our bugzilla-meeting discussion today.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Okay, here we go. This implements the framework for blacklisting modules, and blacklists known-bad versions of DBD::mysql.

Comment 3

[Max Kanat-Alexander]

Also, if anybody else knows other module versions we should blacklist, let me know and we can do it in this bug or in a follow-up bug.

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 247556 [details] [diff] [review]
v1

>+                    blacklist => [qw(3.0003 3.0004 3.0005 3.0006), '_'],

If these are supposed to be regexps, they probably ought to have the dots escaped (twice so it's still escaped after being interpreted?)

Comment 5

[Frédéric Buclin]

Comment on attachment 247556 [details] [diff] [review]
v1

>Index: Bugzilla/Install/Requirements.pm

>+        $blacklisted = grep($vnum =~ /$_/, @{$params->{blacklist}});

Shouldn't it be /\Q$_\E/ ? If you really want to allow regexp in $params->{blacklist}, then you should escape versions, see justdave's comment.

Comment 6

[:glob ✱]

what about blacklisting activestate perl versions?

Comment 7

[Max Kanat-Alexander]

(In reply to comment #6)
> what about blacklisting activestate perl versions?

  We could do that in a separate bug. It'd just be 5.8.6, since 5.8.8 works fine now that we don't use MailTools anymore.

Comment 8

[Frédéric Buclin]

(In reply to comment #4)
>+                    blacklist => [qw(3.0003 3.0004 3.0005 3.0006), '_'],

Would 3\.000[3-6] work?

Comment 9

[Max Kanat-Alexander]

(In reply to comment #8)
> (In reply to comment #4)
> >+                    blacklist => [qw(3.0003 3.0004 3.0005 3.0006), '_'],
> 
> Would 3\.000[3-6] work?

  Oh yes, it would, and it would be much better.

Comment 10

[Max Kanat-Alexander]

Attachment: v2

Okay, fixed that.

Comment 11

[Max Kanat-Alexander]

Attachment: Actual v2

I attached the wrong patch, before.

Comment 12

[Frédéric Buclin]

Comment on attachment 248524 [details] [diff] [review]
Actual v2

Checking for       DBD-mysql (v2.9003)  found v3.0006 (blacklisted)

For MySQL, Bugzilla requires that perl's DBD::mysql 2.9003 be
installed. To install this module, run the following command (as root):


Nit: maybe could we explain what this blacklisted version means? Else it could look a bit confusing, eventually. Anyway, this looks fine. r=LpSolit

Comment 13

[Max Kanat-Alexander]

Checking in Bugzilla/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v  <--  Constants.pm
new revision: 1.65; previous revision: 1.64
done
Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.92; previous revision: 1.91
done
Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.28; previous revision: 1.27
done

Comment 14

[Max Kanat-Alexander]

I forgot to fix the docs usage of DB_MODULE, which caused the tinderboxes to burn. I fixed it as a "checkin fix":

Checking in docs/makedocs.pl;
/cvsroot/mozilla/webtools/bugzilla/docs/makedocs.pl,v  <--  makedocs.pl
new revision: 1.16; previous revision: 1.15
done