360729 - corrupt sqlite database resulting in a crash during local list update

Status: RESOLVED INCOMPLETE

(Toolkit :: Safe Browsing, defect)

Description

[Tony Chang (Google)]

A user reported a crash after browser startup.  After looking at the stack trace, it was due to trying to update a corrupt sqlite database.  We should fail more gracefully if possible.

Comment 1

[Tony Chang (Google)]

Attachment: stack trace of crash

Comment 2

[Tony Chang (Google)]

Corrupt sqlite file is here:
http://ponderer.org/tests/BADBAD-urlclassifier2.sqlite

Comment 3

[Wayne Mery (:wsmwk)]

Shawn, is there enough here to work this?

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> Shawn, is there enough here to work this?
Maybe, but I'd need to see if this is still valid first.  Chances are it doesn't crash anymore.

Comment 5

[Ian Fette (Google)]

Should be easy to test. Given that sqlite is still used as the backend, I would just try corrupting your database and see what happens...

Comment 6

[Shawn Wilsher :sdwilsh]

(In reply to comment #5)
> Should be easy to test. Given that sqlite is still used as the backend, I would
> just try corrupting your database and see what happens...
That's assuming that any corruption would cause the crash, but it is more likely to be a specific type of corruption.

Comment 7

[David Dahl :ddahl]

Do we have a more recent example database to test this with? I think the db referenced in comment 2 is too old to be valid any longer.

Comment 8

[Jesse Ruderman]

We've fixed several bugs of the form "specific type of sqlite corruption leads to crashes" since this bug was filed.  There appears to be no easy way to tell whether we fixed "this" one, so I'm closing this bug report.