User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061114 Camino/1.1a1+ Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061114 Camino/1.1a1+ When dragging a link to an existing open tab, the link actually gets loaded into the leftmost tab rather than the intended one. Dropping links onto empty space on the tab bar still correctly loads the link in a brand new tab. Camino 1.0.3 loads the intended tab correctly so appears to be a regression since then. Reproducible: Always Steps to Reproduce: 1. Open 3 tabs 2. Load a page in the second tab 3. Drag a link on the second tab page to the third tab Actual Results: Link loads in the leftmost tab Expected Results: Link should open in the tab it was dragged onto This is a standard installation of Camino, no extensions/enhancements are installed. Computer is running a stock build of 10.4.8 PPC.
Confirming. Broke between 11/6 and 11/8, so it's almost certainly bug 320668.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Camino1.1
Yeah, for raw URL handling we replaced a loop that did the right thing in the single-url case but a variety of bad things in the multi-url case with a loop that pretty much always does the wrong thing (basically the same behavior as bug 321055).
(In reply to comment #2) > Yeah, for raw URL handling we replaced a loop that did the right thing in the > single-url case but a variety of bad things in the multi-url case with a loop > that pretty much always does the wrong thing (basically the same behavior as > bug 321055). > Ok, cheers for checking - I did see bug 321055 before posting but wasn't sure it was the same thing or not.
This fixes the single-URL case and improves the logic of the tab DnD handler to prevent this kind of thing from happening again by treating all sources of URLs the same. The multi-URL case is still broken, but it's broken in exactly the same way it always has been, and fixing that belongs in bug 321055. (This does change the behavior of DnD of tab groups slightly, in that it used to be special-cased to remove all extra tabs and now is treated like any other multi-URL source, but I think consistency is a good thing.)
Comment on attachment 245904 [details] [diff] [review] fix for the single-bookmark case r=me on the code. I didn't test it though. (Also can you give 8 lines of context in future patches? It makes reviewing easier.)
Attachment #245904 - Flags: review? → review+
Comment on attachment 245904 [details] [diff] [review] fix for the single-bookmark case Someone should put this through its paces.
Same great taste, now without bitrot.
Comment on attachment 247149 [details] [diff] [review] unbitrotted r=ardissone; everything seems halal to me.
Attachment #247149 - Flags: review? → review+
Attachment #247149 - Flags: superreview?(mikepinkerton)
Comment on attachment 247149 [details] [diff] [review] unbitrotted sr=pink
Attachment #247149 - Flags: superreview?(mikepinkerton) → superreview+
Whiteboard: [needs checkin]
Landed on trunk and MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: regression → fixed22.214.171.124
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.