360818 - No RPATH set for signtool and signver

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Christophe Ravel]

Unlike certutil and many other NSS tools, there is no RPATH set for signtool and signver.

# ldd signtool
        libplc4.so =>    (file not found)
        libplds4.so =>   (file not found)
        libnspr4.so =>   (file not found)

Comment 1

[Neil Williams]

There has been quite a bit of work done on signtool to make it use dynamic libraries (see bug 263948). This isn't a duplicate since it is preferable to have signtool use the shared libraries, but when that happens the patch to fix this bug should be undone.

Comment 2

[Neil Williams]

There has been quite a bit of work done on signtool to make it use dynamic libraries (see bug 263948). This isn't a duplicate since it is preferable to have signtool use the shared libraries, but when that happens the patch to fix this bug should be undone.

Comment 3

[Neil Williams]

Mistakenly changed status with last comment.

Comment 4

[Neil Williams]

Attachment: move the block of RPATH settings to start of platlibs.mk

Comment 5

[Neil Williams]

Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

This patch need not be backed out when bug 263948 is fixed--unless someone dislikes the readability quotient.

Comment 6

[Christophe Ravel]

Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

Build and fix tested on Solaris SPARC, Solaris x86, Linux and HP-UX.

Comment 7

[Christophe Ravel]

Tested all.sh on Solaris SPARC, Solaris x86, Linux, HP-UX: no error.

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

Wan-Teh, do you agree with these changes for Linux and other non-Solaris platforms?

Comment 9

[Wan-Teh Chang]

Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

This patch has a harmless bug -- it incorrectly moves the
code for the -rpath-link linker flag.

I encourage you to submit a new patch that doesn't move
the code for the -rpath-linker flag.

If you are pressed for time, you may check in this patch
as is on the NSS_3_11_BRANCH.

But on the NSS trunk, please do not move the code for the
-rpath-linker flag.  It should stay where it is, next to
the Darwin code for the -dylib_file linker flag.

Comment 10

[Wan-Teh Chang]

My previous comment has two instances of a typo.

By "the -rpath-linker flag", I meant "the -rpath-link linker flag".
Specifically, I'm referring to this block of code.

-# If GNU ld is used, we must use the -rpath-link option to tell
-# the linker where to find libsoftokn3.so, an implicit dependency
-# of libnss3.so.
-ifeq (,$(filter-out BSD_OS FreeBSD Linux NetBSD, $(OS_ARCH)))
-EXTRA_SHARED_LIBS += -Wl,-rpath-link,$(DIST)/lib
-endif
-
-ifeq ($(OS_ARCH), SunOS)
-ifdef NS_USE_GCC
-ifdef GCC_USE_GNU_LD
-EXTRA_SHARED_LIBS += -Wl,-rpath-link,$(DIST)/lib
-endif
-endif
-endif

It should not be moved.

Comment 11

[Neil Williams]

Attachment: incorporates Wan-Teh's suggestion

Comment 12

[Neil Williams]

Checking in cmd/platlibs.mk;
/cvsroot/mozilla/security/nss/cmd/platlibs.mk,v  <--  platlibs.mk
new revision: 1.43.2.4; previous revision: 1.43.2.3
done

Checking in cmd/platlibs.mk;
/cvsroot/mozilla/security/nss/cmd/platlibs.mk,v  <--  platlibs.mk
new revision: 1.47; previous revision: 1.46
done