Closed Bug 360818 Opened 14 years ago Closed 13 years ago

No RPATH set for signtool and signver

Categories

(NSS :: Build, defect, P1)

3.11.3
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.11.4

People

(Reporter: christophe.ravel.bugs, Assigned: neil.williams)

Details

Attachments

(1 file, 1 obsolete file)

Unlike certutil and many other NSS tools, there is no RPATH set for signtool and signver.

# ldd signtool
        libplc4.so =>    (file not found)
        libplds4.so =>   (file not found)
        libnspr4.so =>   (file not found)
There has been quite a bit of work done on signtool to make it use dynamic libraries (see bug 263948). This isn't a duplicate since it is preferable to have signtool use the shared libraries, but when that happens the patch to fix this bug should be undone.
Status: NEW → ASSIGNED
There has been quite a bit of work done on signtool to make it use dynamic libraries (see bug 263948). This isn't a duplicate since it is preferable to have signtool use the shared libraries, but when that happens the patch to fix this bug should be undone.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Mistakenly changed status with last comment.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
Status: NEW → ASSIGNED
Attachment #245712 - Flags: superreview?
Attachment #245712 - Flags: review?
Attachment #245712 - Flags: superreview?(nelson)
Attachment #245712 - Flags: superreview?
Attachment #245712 - Flags: review?(christophe.ravel.bugs)
Attachment #245712 - Flags: review?
Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

This patch need not be backed out when bug 263948 is fixed--unless someone dislikes the readability quotient.
Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

Build and fix tested on Solaris SPARC, Solaris x86, Linux and HP-UX.
Attachment #245712 - Flags: review?(christophe.ravel.bugs) → review+
Tested all.sh on Solaris SPARC, Solaris x86, Linux, HP-UX: no error.
Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

Wan-Teh, do you agree with these changes for Linux and other non-Solaris platforms?
Attachment #245712 - Flags: superreview?(wtchang)
Attachment #245712 - Flags: superreview?(nelson)
Attachment #245712 - Flags: review+
Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

This patch has a harmless bug -- it incorrectly moves the
code for the -rpath-link linker flag.

I encourage you to submit a new patch that doesn't move
the code for the -rpath-linker flag.

If you are pressed for time, you may check in this patch
as is on the NSS_3_11_BRANCH.

But on the NSS trunk, please do not move the code for the
-rpath-linker flag.  It should stay where it is, next to
the Darwin code for the -dylib_file linker flag.
Attachment #245712 - Flags: superreview?(wtchang) → superreview+
My previous comment has two instances of a typo.

By "the -rpath-linker flag", I meant "the -rpath-link linker flag".
Specifically, I'm referring to this block of code.

-# If GNU ld is used, we must use the -rpath-link option to tell
-# the linker where to find libsoftokn3.so, an implicit dependency
-# of libnss3.so.
-ifeq (,$(filter-out BSD_OS FreeBSD Linux NetBSD, $(OS_ARCH)))
-EXTRA_SHARED_LIBS += -Wl,-rpath-link,$(DIST)/lib
-endif
-
-ifeq ($(OS_ARCH), SunOS)
-ifdef NS_USE_GCC
-ifdef GCC_USE_GNU_LD
-EXTRA_SHARED_LIBS += -Wl,-rpath-link,$(DIST)/lib
-endif
-endif
-endif

It should not be moved.
Attachment #245712 - Attachment is obsolete: true
Attachment #245777 - Flags: superreview?(nelson)
Attachment #245777 - Flags: review?(christophe.ravel.bugs)
Attachment #245777 - Flags: review?(christophe.ravel.bugs) → review?(wtchang)
Attachment #245777 - Flags: superreview?(nelson) → review+
Attachment #245777 - Flags: review?(wtchang) → review+
Checking in cmd/platlibs.mk;
/cvsroot/mozilla/security/nss/cmd/platlibs.mk,v  <--  platlibs.mk
new revision: 1.43.2.4; previous revision: 1.43.2.3
done

Checking in cmd/platlibs.mk;
/cvsroot/mozilla/security/nss/cmd/platlibs.mk,v  <--  platlibs.mk
new revision: 1.47; previous revision: 1.46
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago13 years ago
Resolution: --- → FIXED
Priority: -- → P1
Target Milestone: --- → 3.11.4
You need to log in before you can comment on or make changes to this bug.