The default bug view has changed. See this FAQ.

No RPATH set for signtool and signver

RESOLVED FIXED in 3.11.4

Status

NSS
Build
P1
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Christophe Ravel, Assigned: Neil Williams)

Tracking

3.11.3
3.11.4

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.56 KB, patch
Wan-Teh Chang
: review+
Nelson Bolyard (seldom reads bugmail)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
Unlike certutil and many other NSS tools, there is no RPATH set for signtool and signver.

# ldd signtool
        libplc4.so =>    (file not found)
        libplds4.so =>   (file not found)
        libnspr4.so =>   (file not found)
(Assignee)

Comment 1

11 years ago
There has been quite a bit of work done on signtool to make it use dynamic libraries (see bug 263948). This isn't a duplicate since it is preferable to have signtool use the shared libraries, but when that happens the patch to fix this bug should be undone.
Status: NEW → ASSIGNED
(Assignee)

Comment 2

11 years ago
There has been quite a bit of work done on signtool to make it use dynamic libraries (see bug 263948). This isn't a duplicate since it is preferable to have signtool use the shared libraries, but when that happens the patch to fix this bug should be undone.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

11 years ago
Mistakenly changed status with last comment.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

11 years ago
Status: REOPENED → NEW
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 4

11 years ago
Created attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk
Attachment #245712 - Flags: superreview?
Attachment #245712 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #245712 - Flags: superreview?(nelson)
Attachment #245712 - Flags: superreview?
Attachment #245712 - Flags: review?(christophe.ravel.bugs)
Attachment #245712 - Flags: review?
(Assignee)

Comment 5

11 years ago
Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

This patch need not be backed out when bug 263948 is fixed--unless someone dislikes the readability quotient.
(Reporter)

Comment 6

11 years ago
Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

Build and fix tested on Solaris SPARC, Solaris x86, Linux and HP-UX.
Attachment #245712 - Flags: review?(christophe.ravel.bugs) → review+
(Reporter)

Comment 7

11 years ago
Tested all.sh on Solaris SPARC, Solaris x86, Linux, HP-UX: no error.
Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

Wan-Teh, do you agree with these changes for Linux and other non-Solaris platforms?
Attachment #245712 - Flags: superreview?(wtchang)
Attachment #245712 - Flags: superreview?(nelson)
Attachment #245712 - Flags: review+

Comment 9

11 years ago
Comment on attachment 245712 [details] [diff] [review]
move the block of RPATH settings to start of platlibs.mk

This patch has a harmless bug -- it incorrectly moves the
code for the -rpath-link linker flag.

I encourage you to submit a new patch that doesn't move
the code for the -rpath-linker flag.

If you are pressed for time, you may check in this patch
as is on the NSS_3_11_BRANCH.

But on the NSS trunk, please do not move the code for the
-rpath-linker flag.  It should stay where it is, next to
the Darwin code for the -dylib_file linker flag.
Attachment #245712 - Flags: superreview?(wtchang) → superreview+

Comment 10

11 years ago
My previous comment has two instances of a typo.

By "the -rpath-linker flag", I meant "the -rpath-link linker flag".
Specifically, I'm referring to this block of code.

-# If GNU ld is used, we must use the -rpath-link option to tell
-# the linker where to find libsoftokn3.so, an implicit dependency
-# of libnss3.so.
-ifeq (,$(filter-out BSD_OS FreeBSD Linux NetBSD, $(OS_ARCH)))
-EXTRA_SHARED_LIBS += -Wl,-rpath-link,$(DIST)/lib
-endif
-
-ifeq ($(OS_ARCH), SunOS)
-ifdef NS_USE_GCC
-ifdef GCC_USE_GNU_LD
-EXTRA_SHARED_LIBS += -Wl,-rpath-link,$(DIST)/lib
-endif
-endif
-endif

It should not be moved.
(Assignee)

Comment 11

11 years ago
Created attachment 245777 [details] [diff] [review]
incorporates Wan-Teh's suggestion
Attachment #245712 - Attachment is obsolete: true
Attachment #245777 - Flags: superreview?(nelson)
Attachment #245777 - Flags: review?(christophe.ravel.bugs)
(Assignee)

Updated

11 years ago
Attachment #245777 - Flags: review?(christophe.ravel.bugs) → review?(wtchang)
Attachment #245777 - Flags: superreview?(nelson) → review+

Updated

11 years ago
Attachment #245777 - Flags: review?(wtchang) → review+
(Assignee)

Comment 12

11 years ago
Checking in cmd/platlibs.mk;
/cvsroot/mozilla/security/nss/cmd/platlibs.mk,v  <--  platlibs.mk
new revision: 1.43.2.4; previous revision: 1.43.2.3
done

Checking in cmd/platlibs.mk;
/cvsroot/mozilla/security/nss/cmd/platlibs.mk,v  <--  platlibs.mk
new revision: 1.47; previous revision: 1.46
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → FIXED
Priority: -- → P1
Target Milestone: --- → 3.11.4
You need to log in before you can comment on or make changes to this bug.