360890 - <xul:resizer> elements should support the 'disabled' attribute

Status: RESOLVED DUPLICATE of bug 357725

(Core :: XUL, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Right now the only way to disable the resizer is to hide it. Unfortunately that changes the positioning of other elements in a XUL window.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch v1.0

Comment 2

[Neil Deakin]

Comment on attachment 245749 [details] [diff] [review]
Patch v1.0

>-       if(mTrackingMouseMove)
>+
>+       if (mTrackingMouseMove && !mDisabled)
>        {

No big deal, but the disabled check doesn't need to happen here. 

>-
>-         doDefault = PR_FALSE;
>        }
>+
>+       doDefault = PR_FALSE;
>      }

What is this change for?

> protected:
> 	eDirection mDirection;
>-	nsRect mWidgetRect;
>+  PRBool mDisabled;
>+  nsRect mWidgetRect;
> }; // class nsResizerFrame

Align mDirection as well while you're at it

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #2)
> No big deal, but the disabled check doesn't need to happen here. 

Well, I guess it depends on what we want to happen here. Say you're in the middle of resizing a window and someone sets disabled to true... Should the resize be allowed to continue until you let go of the mouse? Or should the window instantly stop resizing? I went for the latter, so the disabled check is valid. But I could go either way.

> What is this change for?

If you don't set that to false then it calls the nsTitleFrame message handler... and will move the window!

> Align mDirection as well while you're at it

Will do.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

The fix for this will probably be rolled into the patch in bug 357725.

Comment 5

[Neil Deakin]

Ben, can this be marked a duplicate now?

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Sure thing.

*** This bug has been marked as a duplicate of 357725 ***