360922 - No longer need to re-initialize "Customize Toolbar" sheet when a new tab is opened

Status: RESOLVED INVALID

(Firefox :: General, defect, P2)

Description

[Asaf Romano (gone)]

from browser.js:
  /**
   * XXXmano hack: when a new tab is added while the sheet is visible,
   * the new tabpanel is overlaying the sheet. We workaround this issue by
   * hiding and reopening the sheet when a new tab is added.
   */
  function TabOpenSheetHandler(aEvent) {
    getBrowser().removeEventListener("TabOpen", TabOpenSheetHandler, false);

    document.getElementById("customizeToolbarSheetIFrame")
            .contentWindow.gCustomizeToolbarSheet.done();
    document.getElementById("customizeToolbarSheetBox").hidden = true;
    BrowserCustomizeToolbar();
    
  }
  getBrowser().addEventListener("TabOpen", TabOpenSheetHandler, false);

Bug 130078 fixed the underlying issue, thus we can now get rid of this workaround.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 245760 [details] [diff] [review]
patch

r=me on the parts that aren't bug 354973, and for landing after bug 130078 is relanded.

Comment 3

[Asaf Romano (gone)]

This has been re-implemented using a panel. -> INVALID.