Bookmarks import only imports iCab 2 bookmarks, not iCab 3 bookmarks

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Bookmarks
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: Chris Lawson (gone))

Tracking

({fixed1.8.0.9, fixed1.8.1.1})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.0.9, fixed1.8.1.1

Details

Attachments

(2 attachments)

We offer to import bookmarks from iCab if we detect an iCab profile folder in the user's Preferences folder.  iCab 3 copies the existing Hotlist.html to Hotlist3.html on first launch and uses that file (leaving Hotlist.html) from there on out.

When someone imports iCab bookmarks, they may be importing bookmarks that are quite outdated (or, if they've only ever used iCab 3, we'll fail to detect iCab as a valid browser at all).

We should detect Hotlist3.html in place of, and in addition to, Hotlist.html, like we do for OmniWeb.  (The file format seems to be unchanged, as a manual import works fine.)
(Assignee)

Comment 1

11 years ago
Created attachment 245869 [details] [diff] [review]
one-line fix to add iCab 3 option
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #245869 - Flags: review?(stridey)
Comment on attachment 245869 [details] [diff] [review]
one-line fix to add iCab 3 option

r=ardissone on this redonkulously simple patch.
Attachment #245869 - Flags: review+

Updated

11 years ago
Attachment #245869 - Flags: superreview+

Updated

11 years ago
Attachment #245869 - Flags: review?(stridey) → review+
(Assignee)

Comment 3

11 years ago
Since the patch is fairly harmless and the bug may annoy iCab 3 users, nominating for 1.0.4.

cl
Flags: camino1.0.4?

Comment 4

11 years ago
Checked in on 1.8branch and trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
Created attachment 248350 [details] [diff] [review]
1.8.0branch patch

This is the Camino 1.0.x bitrot police.  Looks like whitespace changes killed this. :P
Flags: camino1.0.4? → camino1.0.4+
Whiteboard: [needs checkin 180 branch]

Comment 6

11 years ago
Checked in on 1.8.0branch for Camino 1.0.4
Keywords: fixed1.8.0.9
Whiteboard: [needs checkin 180 branch]
Moving fixed "1.2" bugs to 1.1 where they were really fixed. Filter on CaminoFixed1.1 for bugmail purposes.
Target Milestone: Camino1.2 → Camino1.1
You need to log in before you can comment on or make changes to this bug.