361001 - Bookmarks import only imports iCab 2 bookmarks, not iCab 3 bookmarks

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We offer to import bookmarks from iCab if we detect an iCab profile folder in the user's Preferences folder.  iCab 3 copies the existing Hotlist.html to Hotlist3.html on first launch and uses that file (leaving Hotlist.html) from there on out.

When someone imports iCab bookmarks, they may be importing bookmarks that are quite outdated (or, if they've only ever used iCab 3, we'll fail to detect iCab as a valid browser at all).

We should detect Hotlist3.html in place of, and in addition to, Hotlist.html, like we do for OmniWeb.  (The file format seems to be unchanged, as a manual import works fine.)

Comment 1

[Chris Lawson (gone)]

Attachment: one-line fix to add iCab 3 option

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 245869 [details] [diff] [review]
one-line fix to add iCab 3 option

r=ardissone on this redonkulously simple patch.

Comment 3

[Chris Lawson (gone)]

Since the patch is fairly harmless and the bug may annoy iCab 3 users, nominating for 1.0.4.

cl

Comment 4

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: 1.8.0branch patch

This is the Camino 1.0.x bitrot police.  Looks like whitespace changes killed this. :P

Comment 6

[froodian (Ian Leue)]

Checked in on 1.8.0branch for Camino 1.0.4

Comment 7

[Samuel Sidler (old account; do not CC)]

Moving fixed "1.2" bugs to 1.1 where they were really fixed. Filter on CaminoFixed1.1 for bugmail purposes.