361016 - Needed an alternate command to zoom to "maximize to fill screen"

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[JK]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1) Gecko/20061115 Camino/1.1a1+ (jedik)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1) Gecko/20061115 Camino/1.1a1+

Since bug 155956 has landed there is no way to revert to the previous behavior (i.e. maximize to fill screen) when using the zoom widget on menu command. Some programs offer this feature if the OPTION (or SHIFT) key is pressed in both cases.

Reproducible: Always




The OPTION key is now used as a modifier for "Zoom All" windows, so maybe the SHIFT key should be used to "zoom to fill screen".

Comment 1

[Torben]

> maybe the SHIFT key should be used to "zoom to fill screen".

This should be a trivial fix. If no one is strongly opposed I'll fix this as soon as I'm finnished debugging some of the other zoom-bugs.

Comment 2

[froodian (Ian Leue)]

Attachment: Patch

Hi Torben,

Hope you don't mind me taking this one, just figured I'd get it out of the way and leave your time for the real bugs. ;)

Comment 3

[Torben]

Comment on attachment 247462 [details] [diff] [review]
Patch

r=me provided that you tested this thoroughly (my build is busted ATM :-( )

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 247462 [details] [diff] [review]
Patch

sr=pink

Comment 5

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk