361030 - Bookmarks refresh problem due to JS error code

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Stephane BERTIN]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0

When I manipulate Bookmark this produce javascript warnings that impact sometimes refresh of bookmarks.
Warning message is :
Warning: reference to undefined property this.BATCH_LIMIT
Source File: chrome://browser/content/bookmarks/bookmarks.js
Line: 1588
Same message on lines : 1627, 1694, 1724.

The problem come from a wrong variable "this.BATCH_LIMIT" which must be replace by "kBATCH_LIMIT".

Hope the code will be updated ;-)

Thanks,
Stéphane.

Reproducible: Always

Steps to Reproduce:
1. select a bookmark and move it in another place.

Comment 1

[Robert Sayre]

yeah, I don't see .BATCH_LIMIT defined anywhere

Comment 2

[Robert Sayre]

Attachment: use kBATCH_LIMIT

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 248133 [details] [diff] [review]
use kBATCH_LIMIT

thanks for catching and fixing this.

it appears to be fall out from jminta's patch from bug #168411, where he replaces some of the calls to this.BATCH_LIMIT with kBATCH_LIMIT, but not all.

my apologies for not catching this during the review process of #168411

it looks like the 1.8 branch has problem as well.

robert, can you land on the MOZILLA_1_8_BRANCH (once you have approval) as well?

Comment 4

[(not reading, please use [e-mail] instead)]

oops, I see robert already has plans to land this on branch (and trunk).

thanks again, robert!

Comment 5

[Joey Minta]

Comment on attachment 248133 [details] [diff] [review]
use kBATCH_LIMIT

yep yep.  I need to run with strict warnings on more often. :-/

Comment 6

[Robert Sayre]

Checking in bookmarks.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarks.js,v  <--  bookmarks.js
new revision: 1.127; previous revision: 1.126
done

Comment 7

[Jay Patel [:jay]]

Comment on attachment 248133 [details] [diff] [review]
use kBATCH_LIMIT

Approved for 1.8 branch, a=jay for drivers.

Comment 8

[Robert Sayre]

Checking in bookmarks.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarks.js,v  <--  bookmarks.js
new revision: 1.104.2.22; previous revision: 1.104.2.21
done

Comment 9

[juan becerra [:juanb]]

Verified using: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070116 BonEcho/2.0.0.2pre

I had these two preferences set to true:
javascript.options.showInConsole
javascript.options.strict

With the new builds I no longer see the warnings in the Error Console when moving bookmarks around.