Last Comment Bug 361076 - Clean up the USE_PTHREADS related code in coreconf/SunOS5.mk.
: Clean up the USE_PTHREADS related code in coreconf/SunOS5.mk.
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Build (show other bugs)
: 3.11.3
: Sun Solaris
: -- trivial (vote)
: 3.12
Assigned To: Wan-Teh Chang
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-11-17 11:20 PST by Wan-Teh Chang
Modified: 2006-11-17 14:00 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Remove USE_PTHREADS, LOCAL_THREADS_ONLY, and IMPL_STRATEGY from SunOS*.mk (1.23 KB, patch)
2006-11-17 11:33 PST, Wan-Teh Chang
christophe.ravel.bugs: review+
Details | Diff | Splinter Review

Description Wan-Teh Chang 2006-11-17 11:20:34 PST
coreconf has some USE_PTHREADS related code that comes from
the old days when NSPR had multiple implementations on Unix.
Today NSPR has only one implementation on all major Unix
platforms.  Therefore the USE_PTHREADS code should be removed,
or we should always set USE_PTHREADS=1.

For the Solaris makefiles in coreconf, only SunOS5.mk uses USE_PTHREADS:

$ grep USE_PTHREADS SunOS*.mk
SunOS5.mk:ifeq ($(USE_PTHREADS),1)
Comment 1 Wan-Teh Chang 2006-11-17 11:33:27 PST
Created attachment 245857 [details] [diff] [review]
Remove USE_PTHREADS, LOCAL_THREADS_ONLY, and IMPL_STRATEGY from SunOS*.mk

USE_PTHREADS means the (current) NSPR implementation that uses pthreads.
LOCAL_THREADS_ONLY means the (obsolete) NSPR implementation that uses
NSPR's own user-level threads.

IMPL_STRATEGY is a tag used in the OBJDIR name to tell the different
implementations apart.  Since there is only one NSPR implementation
on Solaris, we don't need to use IMPL_STRATEGY.
Comment 2 Chris Elving 2006-11-17 11:56:07 PST
Wan-Teh, I don't have the editbugs permission here. However, the patch looks fine to me.
Comment 3 Wan-Teh Chang 2006-11-17 13:15:52 PST
Comment on attachment 245857 [details] [diff] [review]
Remove USE_PTHREADS, LOCAL_THREADS_ONLY, and IMPL_STRATEGY from SunOS*.mk

Chris, I meant to ask Christophe to review the patch.  Sorry
about that.
Comment 4 Wan-Teh Chang 2006-11-17 14:00:28 PST
I checked in the patch on the NSS trunk (3.12).

Note You need to log in before you can comment on or make changes to this bug.