Clean up the USE_PTHREADS related code in coreconf/SunOS5.mk.

RESOLVED FIXED in 3.12

Status

NSS
Build
--
trivial
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

3.11.3
3.12
Sun
Solaris

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
coreconf has some USE_PTHREADS related code that comes from
the old days when NSPR had multiple implementations on Unix.
Today NSPR has only one implementation on all major Unix
platforms.  Therefore the USE_PTHREADS code should be removed,
or we should always set USE_PTHREADS=1.

For the Solaris makefiles in coreconf, only SunOS5.mk uses USE_PTHREADS:

$ grep USE_PTHREADS SunOS*.mk
SunOS5.mk:ifeq ($(USE_PTHREADS),1)
(Assignee)

Comment 1

11 years ago
Created attachment 245857 [details] [diff] [review]
Remove USE_PTHREADS, LOCAL_THREADS_ONLY, and IMPL_STRATEGY from SunOS*.mk

USE_PTHREADS means the (current) NSPR implementation that uses pthreads.
LOCAL_THREADS_ONLY means the (obsolete) NSPR implementation that uses
NSPR's own user-level threads.

IMPL_STRATEGY is a tag used in the OBJDIR name to tell the different
implementations apart.  Since there is only one NSPR implementation
on Solaris, we don't need to use IMPL_STRATEGY.
Attachment #245857 - Flags: review?(chris.elving)

Comment 2

11 years ago
Wan-Teh, I don't have the editbugs permission here. However, the patch looks fine to me.
(Assignee)

Comment 3

11 years ago
Comment on attachment 245857 [details] [diff] [review]
Remove USE_PTHREADS, LOCAL_THREADS_ONLY, and IMPL_STRATEGY from SunOS*.mk

Chris, I meant to ask Christophe to review the patch.  Sorry
about that.
Attachment #245857 - Flags: review?(chris.elving) → review?(christophe.ravel.bugs)

Updated

11 years ago
Attachment #245857 - Flags: review?(christophe.ravel.bugs) → review+
(Assignee)

Comment 4

11 years ago
I checked in the patch on the NSS trunk (3.12).
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.12
You need to log in before you can comment on or make changes to this bug.