361076 - Clean up the USE_PTHREADS related code in coreconf/SunOS5.mk.

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Wan-Teh Chang]

coreconf has some USE_PTHREADS related code that comes from
the old days when NSPR had multiple implementations on Unix.
Today NSPR has only one implementation on all major Unix
platforms.  Therefore the USE_PTHREADS code should be removed,
or we should always set USE_PTHREADS=1.

For the Solaris makefiles in coreconf, only SunOS5.mk uses USE_PTHREADS:

$ grep USE_PTHREADS SunOS*.mk
SunOS5.mk:ifeq ($(USE_PTHREADS),1)

Comment 1

[Wan-Teh Chang]

Attachment: Remove USE_PTHREADS, LOCAL_THREADS_ONLY, and IMPL_STRATEGY from SunOS*.mk

USE_PTHREADS means the (current) NSPR implementation that uses pthreads.
LOCAL_THREADS_ONLY means the (obsolete) NSPR implementation that uses
NSPR's own user-level threads.

IMPL_STRATEGY is a tag used in the OBJDIR name to tell the different
implementations apart.  Since there is only one NSPR implementation
on Solaris, we don't need to use IMPL_STRATEGY.

Comment 2

[Chris Elving]

Wan-Teh, I don't have the editbugs permission here. However, the patch looks fine to me.

Comment 3

[Wan-Teh Chang]

Comment on attachment 245857 [details] [diff] [review]
Remove USE_PTHREADS, LOCAL_THREADS_ONLY, and IMPL_STRATEGY from SunOS*.mk

Chris, I meant to ask Christophe to review the patch.  Sorry
about that.

Comment 4

[Wan-Teh Chang]

I checked in the patch on the NSS trunk (3.12).