Closed Bug 361108 Opened 13 years ago Closed 13 years ago

typo in compareItems()

Categories

(Calendar :: Provider: ICS/WebDAV, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: browning, Unassigned)

References

()

Details

Attachments

(1 file)

I don't fully understand the wrapping issues which compareItems() addresses, but as it stands now it pretty clearly will always return true due to a paste mishap.
Attached patch use aOtherItemSplinter Review
Attachment #245878 - Flags: first-review?
Attachment #245878 - Flags: first-review? → first-review?(lilmatt)
Comment on attachment 245878 [details] [diff] [review]
use aOtherItem

r=lilmatt
Attachment #245878 - Flags: second-review?(jminta)
Attachment #245878 - Flags: first-review?(lilmatt)
Attachment #245878 - Flags: first-review+
Comment on attachment 245878 [details] [diff] [review]
use aOtherItem

nice catch!
Attachment #245878 - Flags: second-review?(jminta) → second-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.