Closed
Bug 361108
Opened 19 years ago
Closed 19 years ago
typo in compareItems()
Categories
(Calendar :: Provider: ICS/WebDAV, defect)
Calendar
Provider: ICS/WebDAV
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: browning, Unassigned)
References
()
Details
Attachments
(1 file)
|
664 bytes,
patch
|
mattwillis
:
first-review+
jminta
:
second-review+
|
Details | Diff | Splinter Review |
I don't fully understand the wrapping issues which compareItems() addresses, but as it stands now it pretty clearly will always return true due to a paste mishap.
|
Reporter | |
Comment 1•19 years ago
|
||
Attachment #245878 -
Flags: first-review?
|
|
Reporter | |
Updated•19 years ago
|
Attachment #245878 -
Flags: first-review? → first-review?(lilmatt)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 245878 [details] [diff] [review]
use aOtherItem
r=lilmatt
Attachment #245878 -
Flags: second-review?(jminta)
Attachment #245878 -
Flags: first-review?(lilmatt)
Attachment #245878 -
Flags: first-review+
|
||
Comment 3•19 years ago
|
||
Comment on attachment 245878 [details] [diff] [review]
use aOtherItem
nice catch!
Attachment #245878 -
Flags: second-review?(jminta) → second-review+
|
|
||
Comment 4•19 years ago
|
||
Patch checked in on MOZILLA_1_8_BRANCH and trunk.
-> FIXED
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•