361128 - Bad description of Privacy tab in page_info_help.xhtml

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Rafal Likus]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061101 SeaMonkey/1.1b Mnenhy/0.7.4.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061101 SeaMonkey/1.1b Mnenhy/0.7.4.0

page_info_help.xhtml
In added section about Privacy tab in SeaMonkey version 1.1 are two simple bugs, proposed change (check my bad English):

-  <li><strong>Page Components</strong>: Under the page URL, there are many
-    categories. To see the list of items in any category, click on the name:

+  <li><strong>Page Components</strong>: Under the page URL, there are many
+    categories. To see the list of items in any category, double click on
+    the name:



-<p><strong>Note</strong>: The sites with a published privacy policy are not
-  very common, so you will usually not see this tab while inspecting pages on
-  the Web.</p>

+<p><strong>Note</strong>: The sites with a published privacy policy are not
+  very common, so if you press one of these buttons, you will usually see only
+  message saying that &brandShortName; is unable to display selected item, 
+  because site does not have published this.</p>

Reproducible: Always



Expected Results:  
Bugs fixed.

Comment 1

[Stefan [:stefanh]]

You could just nuke the "Note" section, the message you get when there is no privacy policy is probably informative enough.

+  <li><strong>Page Components</strong>: Under the page URL, there are many
+    categories. To see the list of items in any category, double click on
+    the name:

"double click" should be "double-click" :-)

Rafal, feel free to attach a diff (and take the bug) - or maybe Giacomo might want to do it?

Comment 2

[Rafal Likus]

Attachment: Proposed patch with Stefan notes.

Proposed patch with Stefan notes.

I do not know what is the next step.

Comment 3

[Stefan [:stefanh]]

You should probably patch the file in suite/locales/en-US/chrome/common/help/ instead. Normally, a fix that is valid on both branch and trunk should (except very special cases) be fixed on trunk first. Then we ask approval for branch. In this case, you could probably ask approval on branch once you got r+ on the patch - the patch can then be checked in on both trunk & branch at the same time (if it gets approved, of course).

-    categories. To see the list of items in any category, click on the name:
+    categories. To see the list of items in any category, double-click on
+	the name:

Nit: The last line should line up with the previous one.

Comment 4

[Rafal Likus]

(In reply to comment #3)

There is tab in this patch - that is why this last line is not lined up. Now I am learning how to get source via cvs for trunk version, but it is painful - this I got from tarball for 1.1b.
And I do not know how long it will take. But will do this.

Comment 5

[Rafal Likus]

Attachment: Proposed patch, from trunk.

Comment 6

[Robert Kaiser]

Comment on attachment 246615 [details] [diff] [review]
Proposed patch with Stefan notes.

Stefan himself is a better reviewer here, he's really a help peer in SeaMonkey, while I'm not.

Comment 7

[Stefan [:stefanh]]

Comment on attachment 246615 [details] [diff] [review]
Proposed patch with Stefan notes.

Actually, this is now obsolete

Comment 8

[Andrew Schultz]

Comment on attachment 246721 [details] [diff] [review]
Proposed patch, from trunk.

landed on trunk

Comment 9

[Stefan [:stefanh]]

(In reply to comment #8)
> (From update of attachment 246721 [details] [diff] [review] [edit])
> landed on trunk
> 
Thanks!