361163 - Remove window state on quit when save pref is off

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

Another small step along the path to auto-save; we need to delete the window state file on quit when the pref is off.  This will be important both to prevent unexpected restoring of old state if the pref is later re-enabled and to make sure we don't run into privacy leaks once we are doing auto-save for crash recovery.

Comment 1

[Stuart Morgan]

Attachment: fix

Comment 2

[Chris Lawson (gone)]

Comment on attachment 245905 [details] [diff] [review]
fix

Looks good here.

Comment 3

[Mike Pinkerton (not reading bugmail)]

why not just remove it when they turn the pref off? why slow down every quit trying to clean up this file when it won't be there 99% of the time?

Comment 4

[Stuart Morgan]

My thinking was that we will want to have saving happen all the time for everyone once the crash recovery stuff is in (because who wouldn't want their pages recovered after a crash?) in which case the file will pretty much always be there, but shouldn't stick around in the normal quit case for the people who don't want restoring after a normal quit and relaunch.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 245905 [details] [diff] [review]
fix

*shrug* ok. sr=pink

Comment 6

[Stuart Morgan]

Checked in on trunk and MOZILLA_1_8_BRANCH.