Remove window state on quit when save pref is off

RESOLVED FIXED

Status

defect
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Tracking

({fixed1.8.1.1})

Details

Attachments

(1 attachment)

fix
1.89 KB, patch
bugzilla-graveyard
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review
Assignee

Description

13 years ago
Another small step along the path to auto-save; we need to delete the window state file on quit when the pref is off.  This will be important both to prevent unexpected restoring of old state if the pref is later re-enabled and to make sure we don't run into privacy leaks once we are doing auto-save for crash recovery.
Assignee

Comment 1

13 years ago
Posted patch fixSplinter Review
Attachment #245905 - Flags: review?
Comment on attachment 245905 [details] [diff] [review]
fix

Looks good here.
Attachment #245905 - Flags: review? → review+
Assignee

Updated

13 years ago
Attachment #245905 - Flags: superreview?(mikepinkerton)
why not just remove it when they turn the pref off? why slow down every quit trying to clean up this file when it won't be there 99% of the time?
Assignee

Comment 4

13 years ago
My thinking was that we will want to have saving happen all the time for everyone once the crash recovery stuff is in (because who wouldn't want their pages recovered after a crash?) in which case the file will pretty much always be there, but shouldn't stick around in the normal quit case for the people who don't want restoring after a normal quit and relaunch.
Comment on attachment 245905 [details] [diff] [review]
fix

*shrug* ok. sr=pink
Attachment #245905 - Flags: superreview?(mikepinkerton) → superreview+
Assignee

Comment 6

13 years ago
Checked in on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.