Remove window state on quit when save pref is off

RESOLVED FIXED

Status

Camino Graveyard
General
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.1})

Trunk
PowerPC
Mac OS X
fixed1.8.1.1

Details

Attachments

(1 attachment)

fix
1.89 KB, patch
Chris Lawson (gone)
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Another small step along the path to auto-save; we need to delete the window state file on quit when the pref is off.  This will be important both to prevent unexpected restoring of old state if the pref is later re-enabled and to make sure we don't run into privacy leaks once we are doing auto-save for crash recovery.
(Assignee)

Comment 1

11 years ago
Created attachment 245905 [details] [diff] [review]
fix
Attachment #245905 - Flags: review?

Comment 2

11 years ago
Comment on attachment 245905 [details] [diff] [review]
fix

Looks good here.
Attachment #245905 - Flags: review? → review+
(Assignee)

Updated

11 years ago
Attachment #245905 - Flags: superreview?(mikepinkerton)
why not just remove it when they turn the pref off? why slow down every quit trying to clean up this file when it won't be there 99% of the time?
(Assignee)

Comment 4

11 years ago
My thinking was that we will want to have saving happen all the time for everyone once the crash recovery stuff is in (because who wouldn't want their pages recovered after a crash?) in which case the file will pretty much always be there, but shouldn't stick around in the normal quit case for the people who don't want restoring after a normal quit and relaunch.
Comment on attachment 245905 [details] [diff] [review]
fix

*shrug* ok. sr=pink
Attachment #245905 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 6

11 years ago
Checked in on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.