Closed Bug 361195 Opened 19 years ago Closed 18 years ago

Removing obsolete strings from calendar.properties

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Sunbird 0.5

People

(Reporter: bmo.cec, Assigned: bmo.cec)

Details

Attachments

(1 file, 2 obsolete files)

There are 67 obsolete strings in calendar.properties file. They should be removed to ease the readability of this file. A grep -R for the following strings in /calendar directory shows that these strings are only present in calendar.properties file. Strings list : AllDayEvents noEventsOrTasksToImport aboutToImportNewEventsTitle aboutToImportNewEvents aboutToImportDupEventsTitle aboutToImportDupEvents aboutToImportNewTasksTitle aboutToImportNewTasks aboutToImportDupTasksTitle aboutToImportDupTasks discardAll importAll promptForEach addDuplicate eventTitle eventStartTime eventEndTime eventSummary eventWhen eventWhere concurrentEdit deleteCalendarTitle deleteCalendarMessage deleteCalendarOnly deleteCalendarAndFile weekDayMonthLabel Week 1001 Save filepickerDefServerString filtervCalendar filterXcs filterXml filterRtf filterHtml filterCsv filterOutlookCsv filterRdf outlookCSVTitle outlookCSVStartDate outlookCSVStartTime outlookCSVEndDate outlookCSVEndTime outlookCSVAllDayEvent outlookCSVAlarm outlookCSVAlarmDate outlookCSVAlarmTime outlookCSVCategories outlookCSVDescription outlookCSVLocation outlookCSVPrivate outlookCSVValueTrue outlookCSVValueFalse outlookCSVDateParseConfirm httpError otherError contentError setMasterPassword password_not_set failed_pw_change incorrect_pw pw_change_ok pw_erased_ok pw_not_wanted pw_empty_warning pw_change_success_title pw_remove_button
Attached patch Patch removing obsolete strings (obsolete) — — Splinter Review
Attachment #245942 - Flags: first-review?(lilmatt)
I think we wanted to keep the outlook strings around for when we finally get a full-fledged csv importer. mvl would know for sure.
Leave the outlook items in there. I still don't know what the best solution to importing outlook is. Loosing all the translated fields names is a bad idea in this case. (yes, there is cvs history, but that's a pain to do for all the localizations)
'leave them in' means don't remove from calendar.properties.
Attached patch This one adds back Outlook related strings (obsolete) — — Splinter Review
This patch adds back Outlook related strings to address mvl's comment
Attachment #245942 - Attachment is obsolete: true
Attachment #246078 - Flags: first-review?(lilmatt)
Attachment #245942 - Flags: first-review?(lilmatt)
Comment on attachment 246078 [details] [diff] [review] This one adds back Outlook related strings I did a grep -r for each of the removed strings and it came up clean. r=lilmatt AllDayEvents noEventsOrTasksToImport aboutToImportNewEventsTitle aboutToImportNewEvents aboutToImportDupEventsTitle aboutToImportDupEvents aboutToImportNewTasksTitle aboutToImportNewTasks aboutToImportDupTasksTitle aboutToImportDupTasks discardAll importAll promptForEach addDuplicate eventTitle eventStartTime eventEndTime eventSummary eventWhen eventWhere concurrentEdit deleteCalendarTitle deleteCalendarMessage deleteCalendarOnly deleteCalendarAndFile weekDayMonthLabel Week 1001 Save filepickerDefServerString filtervCalendar filterXcs filterXml filterRtf filterHtml filterCsv filterOutlookCsv filterRdf httpError otherError contentError
Attachment #246078 - Flags: first-review?(lilmatt) → first-review+
Attached patch Patch v3 — — Splinter Review
Providing a new patch because landed bug 360513 broke the previous one. lilmatt : could you forward your first-review+ please ?
Attachment #246078 - Attachment is obsolete: true
Attachment #247699 - Flags: second-review?
Attachment #247699 - Flags: second-review? → second-review?(dmose)
Comment on attachment 247699 [details] [diff] [review] Patch v3 r=lilmatt
Attachment #247699 - Flags: first-review+
Comment on attachment 246078 [details] [diff] [review] This one adds back Outlook related strings r=dmose
Attachment #246078 - Flags: second-review+
Comment on attachment 247699 [details] [diff] [review] Patch v3 Moving forward dmose's r+ as the updated patch simply unbitrots the one he approved.
Attachment #247699 - Flags: second-review?(dmose) → second-review+
Patch v3 checked in on MOZILLA_1_8_BRANCH and trunk. -> FIXED
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: