361283 - Changing collapse preference doesn't update timestamps

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[James Ross]

When you change the collapse preference(s), the timestamps will be displayed differently - but no update is triggered. Easy to fix.

Comment 1

[James Ross]

Attachment: Update timestamps when collapse is changed

Some day, we might update the rest of the display too.

Comment 2

[:Gijs (he/him)]

Comment on attachment 310011 [details] [diff] [review]
Update timestamps when collapse is changed

>Index: xul/content/prefs.js
> <snip>
>@@ -1027,12 +1035,13 @@ function onDCCUserPrefChanged(user, pref
>             case "displayHeader":
>                 view.dispatch("sync-header");
>                 break;
> 
>             case "timestamps":
>             case "timestamps.display":
>+            case "collapseMsgs":
>                 view.dispatch("sync-timestamp");
>                 break;

Would it make sense to add collapseActions here while we're at it? Or do CTCP Actions not work on DCC views (I thought they did, but I have a headache and am not entirely well, so maybe my brain is lying to me). I know there is no pref atm, but I *think* (insert another note on mental health) that it would be trivial to add that. Correct?

Comment 3

[James Ross]

CTCP actions should work in DCC chat (right now, in theory), but I left it off because there was no pref. I can add it anyway, but wont be adding the pref in this bug.

Comment 4

[:Gijs (he/him)]

Comment on attachment 310011 [details] [diff] [review]
Update timestamps when collapse is changed

ok, r=me

Comment 5

[James Ross]

Checked in --> FIXED with collapseActions added to the DCC switch as well.